1363742 - delete code that references mozilla-aurora in buildbot configs and taskcluster

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Kim Moir [:kmoir] ET]

The code has to stay in place until June 12, 2017, then it can be deleted.  

We can start working on this bug in early June.  If we start earlier, the patches will get bitrotted.

Comment 1

[Sebastian Pacurar [:spacurar]]

Can I work on this as soon as June starts ?

Comment 2

[Alin Selagea [:aselagea]]

Well, since we have a volunteer, I'd say go for it! :-)

Comment 4

[Sebastian Pacurar [:spacurar]]

Attachment: bug_1363742_bb-configs.patch

Removed code that references mozilla-aurora in bb-configs.

Comment 5

[Sebastian Pacurar [:spacurar]]

Attachment: bug_1363742_tc-mozilla-inbound.patch

Removed code that references mozilla-aurora in m-i taskcluster.

Comment 6

[Kim Moir [:kmoir] ET]

Comment on attachment 8876113 [details] [diff] [review]
bug_1363742_tc-mozilla-inbound.patch

The patch needs to be rebased, the parts for ci/test/tests.yml don't apply cleanly anymore.  But I'm sure that will work when fixed.

Can the references to aurora in 

taskgraph/util/scriptworker.py be removed?  Might be good to ask aki about that.

Comment 7

[Sebastian Pacurar [:spacurar]]

Attachment: bug_1363742_treeherder.patch

This patch removes mozilla-aurora code from treeherder repository. 

I also fixed the m-i patch, waiting for aki now to ask about scriptworker.py

Comment 8

[Kim Moir [:kmoir] ET]

Comment on attachment 8876710 [details] [diff] [review]
bug_1363742_treeherder.patch

Since this is touching the treeherder code, you should ask the treeherder folks (edmorley etc) to review since they will ultimately be responsible for merging this code. I think they usually prefer pull requests against their git repository.  As a side note, not sure if they want aurora to stay visible for a while in treeherder, worth asking.

Comment 9

[Sebastian Pacurar [:spacurar]]

Attachment: bug_1363742_v2_tc-mozilla-inbound.patch

Fixed the problem with ci/test/tests.yml

:aki confirmed that references to mozilla-aurora can be removed from scriptworker.py

Comment 10

[Sebastian Pacurar [:spacurar]]

Should the references to mozilla-aurora from treeherder repo be removed as well?

https://bugzilla.mozilla.org/attachment.cgi?id=8876710  this is the code I removed in my patch

Comment 11

[Ed Morley [:emorley]]

The repo should be marked as onhold instead - we also use GitHub pull requests rather than pathes. However we need to first confirm whether people will still need to access the old data in Treeherder for the short term.

Please file a new bug in Tree Management::Treeherder that depends on this one, where we can discuss further.

Thank you for hunting down old code! :-)

Comment 12

[Kim Moir [:kmoir] ET]

Comment on attachment 8876769 [details] [diff] [review]
bug_1363742_v2_tc-mozilla-inbound.patch

I think you need to rebase again but it looks good

Comment 13

[Sebastian Pacurar [:spacurar]]

Attachment: bug_1363742_v3_tc-mozilla-inbound.patch

I rebased it. Please check if it is ok now. It works on my side. Can you please push this one and the buildbot one after if everything is ok?

Comment 14

[Kim Moir [:kmoir] ET]

Comment on attachment 8878546 [details] [diff] [review]
bug_1363742_v3_tc-mozilla-inbound.patch

looks good but you added a space here


-], [
-    'beta', set([
+], [ 
+     'beta', set([

should be good to land with this fix.

Comment 15

[Kim Moir [:kmoir] ET]

I didn't land this this afternoon because I was in meetings all morning and am always hesitant to land changes on Friday afternoon so I'll let you and Alin land it on Monday.

Comment 16

[Alin Selagea [:aselagea]]

Comment on attachment 8876112 [details] [diff] [review]
bug_1363742_bb-configs.patch

https://hg.mozilla.org/build/buildbot-configs/rev/aa45ca2543f1
https://hg.mozilla.org/build/buildbot-configs/rev/82c352b72046

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca9a7fa7d6a9
delete code that references mozilla-aurora in buildbot configs and taskcluster, r=kmoir (patch by spacurar)

Comment 18

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/34d68a6a1382
Backed out changeset ca9a7fa7d6a9 for breaking decision task

Comment 19

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Pulsebot from comment #17)
> Pushed by [e-mail]:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/ca9a7fa7d6a9
> delete code that references mozilla-aurora in buildbot configs and
> taskcluster, r=kmoir (patch by spacurar)

Fwiw - this https://hg.mozilla.org/build/buildbot-configs/diff/aa45ca2543f1/mozilla/gecko_versions.json made my day! \o/
Kill it with fire! :D

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/47b082ccc20d
delete code that references mozilla-aurora in buildbot configs and taskcluster, r=kmoir (patch by spacurar)

Comment 21

[Alin Selagea [:aselagea]]

Comment on attachment 8878546 [details] [diff] [review]
bug_1363742_v3_tc-mozilla-inbound.patch

The initial patch was backed out as the gecko decision task failed. Sebastian fixed it and the second decision task is now green.

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=47b082ccc20db3d71c4c02e6f16e91405e09e6ef

Comment 22

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/47b082ccc20d