1372559 - [l10nstats] update to compare-locales 2.0 json format

Status: RESOLVED FIXED

(Webtools Graveyard :: Elmo, enhancement)

Description

[Axel Hecht [:Pike]]

bug 1372558 will start generating the data for compare-locales in the new json format, elmo needs to be able to show that.

Given that the ES index won't change, we can land this support ahead of generating the data, and show both formats with runtime detection.

Ride-along: stop pretending that the json is in build logs.

Comment 1

[Axel Hecht [:Pike]]

Attachment: Handle both old and new json format

This is 4 commits, the first two are cosmetic cleanup, removing dead code and flaking.
Then I transform the compare view to a class-based view, so that I can insert testing json data by subclassing, and create a test.
Then I add a second variant to detect the new json format, and adapt it slightly differently in a way that works for the template.

Tested against a local setup with the new version of compare-locales, and missing/obsolete and errors all work.

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 8877544 [details] [review]
Handle both old and new json format

Matjaz, is this something you could review? When you're back, that is.

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 8877544 [details] [review]
Handle both old and new json format

... actually, this is the review I talked about moving from matjaz to stas.

Comment 4

[[github robot]]

Commits pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/27ae3626f709fe67c76a6c01c4f631ade4596595
bug 1372559, drop reading json data from build logs

https://github.com/mozilla/elmo/commit/ed7192102c3280f770bc7cb989c2b399af941410
bug 1372559, make compare view a template view to add tests, add tests

https://github.com/mozilla/elmo/commit/f77445a420144967702be0bfa78b92d185982ef0
bug 1372559, support new and old json data format from compare-locales

Comment 5

[Axel Hecht [:Pike]]

This is in production now.