Remove non-restartless add-on support

NEW
Unassigned

Status

()

Toolkit
Add-ons Manager
a month ago
17 days ago

People

(Reporter: andym, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

a month ago
With Firefox 57 non-restartless add-ons will no longer be supported. 

This makes the assumption that the e10srollout extension will no longer be used as well.

Comment 1

a month ago
The last sentence in comment 0 is specifically about the code in the addons manager that supports e10srollout.  For example (though there are many other instance as well):
http://searchfox.org/mozilla-central/rev/61054508641ee76f9c49bcf7303ef3cfb6b410d2/toolkit/mozapps/extensions/internal/XPIProvider.jsm#4099-4100

I don't know whether it makes to sense to create a separate bug to remove the code in the addons manager that supports e10srollout post-57.  But lets start with getting a common understanding of what the plans are post-57.  Felipe: with only webextensions being supported on release beginning in 57, will e10srollout stop considering addons?  What about the annoying corner case of Nightly users who have flipped a preference to allow legacy extensions to run?  (For the record, we've been pretty clear that we're not making any commitments to support legacy extensions after 57 so I think that enabling e10s/e10s-multi even if there are incompatible legacy extensions installed for these users would be fine...)
Flags: needinfo?(felipc)
My understanding is that on release it won't be possible to flip that pref and allow legacy extensions to run, right?

e10srollout will become mostly obsolete post-57. We could even remove the code for it but I'd prefer to wait one cycle to make sure we don't need to roll back anything..  In theory, there needs to be no modification to the e10srollout code because if only webextensions are enabled, that code you pointed out will always allow e10s (i.e., no enabled addon will block e10s).

So the presence of e10srollout will just serve to keep the cohorts tagging for us to see that everything is working as expected.

As for Nightly, there's nothing to worry about. The e10srollout addon doesn't even run there (or, rather, it runs but returns immediately). e10s is directly preffed to true on Nightly, and we've always let e10s/e10s-multi run side-by-side with legacy addons.
Flags: needinfo?(felipc)

Comment 3

a month ago
(In reply to :Felipe Gomes (needinfo me!) from comment #2)
> My understanding is that on release it won't be possible to flip that pref
> and allow legacy extensions to run, right?

correct

> e10srollout will become mostly obsolete post-57. We could even remove the
> code for it but I'd prefer to wait one cycle to make sure we don't need to
> roll back anything..  In theory, there needs to be no modification to the
> e10srollout code because if only webextensions are enabled, that code you
> pointed out will always allow e10s (i.e., no enabled addon will block e10s).

Right, but this bug is about removing support for non-restartless addons and e10srollout (or more precisely, the code in the add-ons manager that supports it) currently uses that support by making an individual extension look like it requires restart enabling/disabling that extension changes the e10s decision.  So it sounds like nothing we're doing right now and nothing we're planning to do would actually use that capability in 57, but we need to balance this with, as you said, leaving it there for a little while in case some catastrophic happens and we need to roll back.
Yeah. So I believe the best way to look at it is: don't let the e10srollout code be the only blocker for removing that support. If you're comfortable with removing it from the code, we can remove it from e10srollout too. If you're leaving that support for a little while just in case, let's leave the e10srollout use of it too.

Comment 5

a month ago
(In reply to :Felipe Gomes (needinfo me!) from comment #2)
> My understanding is that on release it won't be possible to flip that pref and allow legacy extensions to run, right?

(Just a Nightly tester.) This sounds like it would be possible to re-enable legacy addon/theme support in Nightly 57 (and maybe later) via pref. Scares me a bit. I thought legacy non-system-addons/-themes would finally get prohibited within Nightly 57.

Comment 6

a month ago
(In reply to Darkspirit from comment #5)
> (In reply to :Felipe Gomes (needinfo me!) from comment #2)
> > My understanding is that on release it won't be possible to flip that pref and allow legacy extensions to run, right?
> 
> (Just a Nightly tester.) This sounds like it would be possible to re-enable
> legacy addon/theme support in Nightly 57 (and maybe later) via pref. Scares
> me a bit. I thought legacy non-system-addons/-themes would finally get
> prohibited within Nightly 57.

No, this is detailed at the wiki page linked from https://bugzilla.mozilla.org/show_bug.cgi?id=1336576#c4
You need to log in before you can comment on or make changes to this bug.