1373016 - Remove or update customization mode infopanel

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, enhancement, P1)

Description

[Justin Dolske [:Dolske]]

Attachment: Screen Shot

The first time customization mode is opened, we show a little infopanel that explains what can be done.

Assuming we want to keep this, the illustration should be updated since it shows the pre-Photon hamburger menu (icons in a grid) and other browser UI.

Might also want to tweak the copy, I'm not sure why it says "any of the above". 

Also it links to https://support.mozilla.org/en-US/kb/customize-firefox-controls-buttons-and-toolbars?as=u&utm_source=inproduct, which should be updated too.

Comment 1

[:Gijs (he/him)]

The super-safe / low effort option for photon if we can't get to this would be to perma-pref this off, as there's a pref we check before showing it (which we use to avoid showing it more than once, but can obviously leverage to just never show this).

I'd be in favour of just removing it - I think we will have an onboarding tour that helps with the important bits, not convinced that a one-time help panel here will be that useful.

Comment 3

[:Gijs (he/him)]

Attachment: Bug 1373016 - switch from a tip panel to a permanent message for empty overflow panels in customize mode for photon,

Review commit: https://reviewboard.mozilla.org/r/152854/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/152854/

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8881786 [details]
Bug 1373016 - switch from a tip panel to a permanent message for empty overflow panels in customize mode for photon,

https://reviewboard.mozilla.org/r/152854/#review158062

::: browser/themes/shared/customizableui/customizeMode.inc.css:581
(Diff revision 1)
> +#customization-panelHolder > #widget-overflow-fixed-list:not(:empty) {
> +  padding-bottom: 50px; /* Make sure there's always space to drop stuff. */
> +}
> +
> +#customization-panelHolder > #widget-overflow-fixed-list:empty {
> +  background: url("chrome://browser/skin/customizableui/empty-overflow-panel.png") center top 10px/218px 134px no-repeat;

Please use the long-hand version of these properties.

What does the 218px number come from?

Comment 5

[:Gijs (he/him)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #4)
> What does the 218px number come from?

It's the size of the image - 218x134. I don't know why it's that size, hence centering it...

Comment 6

[:Gijs (he/him)]

Comment on attachment 8881786 [details]
Bug 1373016 - switch from a tip panel to a permanent message for empty overflow panels in customize mode for photon,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152854/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdcdd4d23c77
switch from a tip panel to a permanent message for empty overflow panels in customize mode for photon, r=jaws

Comment 8

[:Gijs (he/him)]

Comment on attachment 8881786 [details]
Bug 1373016 - switch from a tip panel to a permanent message for empty overflow panels in customize mode for photon,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152854/diff/2-3/

Comment 9

[Carsten Book [:Tomcat]]

backed out for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=110681213&repo=autoland

Comment 10

[:Gijs (he/him)]

(In reply to Carsten Book [:Tomcat] from comment #9)
> backed out for bustage like
> https://treeherder.mozilla.org/logviewer.html#?job_id=110681213&repo=autoland

I am an idiot. Forgot to 'hg add' the image files. Fixed now.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5de26737d215
switch from a tip panel to a permanent message for empty overflow panels in customize mode for photon, r=jaws

Comment 12

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49739b62d4dc
Backed out changeset bdcdd4d23c77 for bustage

Comment 13

[Carsten Book [:Tomcat]]

sorry gijs, backed out for https://treeherder.mozilla.org/logviewer.html#?job_id=110688226&repo=autoland

Comment 14

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2aff6fc075d
Backed out changeset 5de26737d215 for failure like missing chrome://browser/skin/customizableui/[e-mail] referenced from chrome://browser/skin/browser.css

Comment 15

[:Gijs (he/him)]

Comment on attachment 8881786 [details]
Bug 1373016 - switch from a tip panel to a permanent message for empty overflow panels in customize mode for photon,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152854/diff/3-4/

Comment 16

[:Gijs (he/him)]

So I missed the fact that the styling for the hidpi images wasn't ifdef'd out, because it was in osx-only and I wrote the patch on (hidpi!) windows, and my new styling was in a shared file... I ran the failing test on Windows prior to the previous landing, and it passed there. :-(

X-ref bug 1343824 which we'll end up fixing once we unship the non-MOZ_PHOTON_THEME configuration.

Anyway, ifdef'd out the OS X hidpi old-style imagery in browser.css, pulled the changes onto my mbp, re-ran the test there, passes. So, fingers crossed, let's try this a third time (as I don't see any other relevant orange on the previous push...).

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbf0368eea83
switch from a tip panel to a permanent message for empty overflow panels in customize mode for photon, r=jaws

Comment 18

[Carsten Book [:Tomcat]]

backed out for https://treeherder.mozilla.org/logviewer.html#?job_id=110718365&repo=autoland on windows

Comment 19

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30e0a16443c1
Backed out changeset cbf0368eea83 for unused whitelist entry: chrome://browser/skin/customizableui/[e-mail] -

Comment 20

[:Gijs (he/him)]

Comment on attachment 8881786 [details]
Bug 1373016 - switch from a tip panel to a permanent message for empty overflow panels in customize mode for photon,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/152854/diff/4-5/

Comment 21

[:Gijs (he/him)]

I am having such a great day. :-)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd84731804b7

looks green (apart from OS X, which is lagging behind, but was green on https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=cbf0368eea83774a4ecf41b798f1c6b442b72568 , so let's try again...

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f0b68036edb
switch from a tip panel to a permanent message for empty overflow panels in customize mode for photon, r=jaws

Comment 23

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9f0b68036edb

Comment 24

[u554753]

Verified on Windows and Ubuntu, but I'm still seeing this on the Mac build as of 7/5's nightly. Is this intended?

Comment 25

[u554753]

I noticed on Comment 21 that it was having issues, but it doesn't look like it ever went through.

Comment 26

[u554753]

Attachment: Screen Shot 2017-07-05 at 1.21.15 PM.png

Screenshot of Customize window on Mac OSX

photon.structure.enabled is set to true
Build is 20170705150303

Comment 27

[u554753]

We figured out the issue on IRC; Verified on Windows, Mac, and Linux.