Closed
Bug 1373065
Opened 7 years ago
Closed 7 years ago
Tidy up leftover social API sidebar bits
Categories
(Firefox Graveyard :: SocialAPI, defect)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: Gijs, Unassigned)
References
Details
https://dxr.mozilla.org/mozilla-central/search?q=social+sidebar+-path%3Aobj-x+-file%3Abrowser.inc+-file%3Aaddons.json+-file%3AReadability.js&redirect=false has a number of hits that, AFAICT can almost all be removed now that the social sidebar is gone (as of Fx51, bug 1289549): addon-sdk/source/test/addons/private-browsing-supported/sidebar/utils.js 'menu_socialSidebar', addon-sdk/source/test/sidebar/utils.js 'menu_socialSidebar', browser/locales/en-US/chrome/browser/browser.properties social.error.closeSidebar.label=Close This Sidebar social.error.closeSidebar.accesskey=C browser/themes/linux/customizableui/panelUI.css /* subviewbutton entries for social sidebars have images that come from external browser/themes/windows/customizableui/panelUI.css /* subviewbutton entries for social sidebars have images that come from external toolkit/components/telemetry/Histograms.json "SOCIAL_SIDEBAR_STATE": { "description": "Social Sidebar state 0: closed, 1: opened. Toggling between providers will result in a higher opened rate." "SOCIAL_SIDEBAR_OPEN_DURATION": { toolkit/components/telemetry/histogram-whitelists.json "SOCIAL_SIDEBAR_OPEN_DURATION", "SOCIAL_SIDEBAR_STATE", "SOCIAL_SIDEBAR_OPEN_DURATION", "SOCIAL_SIDEBAR_STATE",
Reporter | ||
Comment 1•7 years ago
|
||
Looks like this got fixed, minus the sdk test-only stuff, which we can probably live with.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
Updated•5 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•