1373065 - Tidy up leftover social API sidebar bits

Status: RESOLVED WORKSFORME

(Firefox Graveyard :: SocialAPI, defect)

Description

[:Gijs (he/him)]

https://dxr.mozilla.org/mozilla-central/search?q=social+sidebar+-path%3Aobj-x+-file%3Abrowser.inc+-file%3Aaddons.json+-file%3AReadability.js&redirect=false

has a number of hits that, AFAICT can almost all be removed now that the social sidebar is gone (as of Fx51, bug 1289549):


addon-sdk/source/test/addons/private-browsing-supported/sidebar/utils.js
'menu_socialSidebar',

addon-sdk/source/test/sidebar/utils.js
'menu_socialSidebar',

browser/locales/en-US/chrome/browser/browser.properties
social.error.closeSidebar.label=Close This Sidebar
social.error.closeSidebar.accesskey=C

browser/themes/linux/customizableui/panelUI.css
/* subviewbutton entries for social sidebars have images that come from external

browser/themes/windows/customizableui/panelUI.css
/* subviewbutton entries for social sidebars have images that come from external

toolkit/components/telemetry/Histograms.json
"SOCIAL_SIDEBAR_STATE": {
"description": "Social Sidebar state 0: closed, 1: opened.  Toggling between providers will result in a higher opened rate."
"SOCIAL_SIDEBAR_OPEN_DURATION": {

toolkit/components/telemetry/histogram-whitelists.json
"SOCIAL_SIDEBAR_OPEN_DURATION",
"SOCIAL_SIDEBAR_STATE",
"SOCIAL_SIDEBAR_OPEN_DURATION",
"SOCIAL_SIDEBAR_STATE",

Comment 1

[:Gijs (he/him)]

Looks like this got fixed, minus the sdk  test-only stuff, which we can probably live with.