Open Bug 1373212 Opened 5 years ago Updated 3 years ago

[e10s] DDE WWW_GetWindowInfo broken

Categories

(Toolkit :: Startup and Profile System, defect, P3)

54 Branch
Unspecified
Windows
defect

Tracking

()

People

(Reporter: vopl, Unassigned)

References

Details

Attachments

(2 files)

1.39 KB, text/plain
Details
39.00 KB, application/octet-stream
Details
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.86 Safari/537.36

Steps to reproduce:

Run Firefox with option "browser.tabs.remote.autostart.2=true" (Firefox has multiple processes), open an tab with valid web url (http://example.com/ for example).
Now try to retrieve page Url and Title via DDE WWW_GetWindowInfo


Actual results:

DdeClientTransaction in my application returns no data, DdeGetLastError returns DMLERR_NOTPROCESSED.

remark: If page is an special (about:config for example) - DDE data comes normally
remark: If Firefox work in single-process mode (with browser.tabs.remote.autostart.2 disabled) - DDE data comes normally



Expected results:

DdeClientTransaction in my application returns data without errors
OS: Unspecified → Windows
Component: Untriaged → General
Component: General → Startup and Profile System
Product: Firefox → Toolkit
Summary: DDE WWW_GetWindowInfo broken → [e10s] DDE WWW_GetWindowInfo broken
vopl, is there a simple testcase (like .exe) to reproduce the issue with this API?
Flags: needinfo?(vopl)
I think we should remove this API surface. I'm not sure what it's valid purpose is, but it's not possible to implement effectively with e10s and it's a privacy risk that appears to have dubious value.

rstrong thoughts? current impl is at https://dxr.mozilla.org/mozilla-central/rev/da66c4a05fda49d457d9411a7092fed87cf9e53a/toolkit/xre/nsNativeAppSupportWin.cpp#943
Attached file simple testcase
Flags: needinfo?(vopl)
Flags: needinfo?(robert.strong.bugs)
(In reply to Benjamin Smedberg [:bsmedberg] from comment #2)
> I think we should remove this API surface. I'm not sure what it's valid
> purpose is, but it's not possible to implement effectively with e10s and
> it's a privacy risk that appears to have dubious value.
> 
> rstrong thoughts? current impl is at
> https://dxr.mozilla.org/mozilla-central/rev/
> da66c4a05fda49d457d9411a7092fed87cf9e53a/toolkit/xre/nsNativeAppSupportWin.
> cpp#943
In my experience DDE has always been somewhat problematic due to various OS bugs with DDE which is why I disabled using it for shell integration in 2012 (bug 491947).

I agree with your summary. It appears that jimm has done some work to remove DDE support in bug 513742.
Flags: needinfo?(robert.strong.bugs)
Status: UNCONFIRMED → NEW
Depends on: 513742
Ever confirmed: true
Priority: -- → P3
Chrome does not support DDE (including WWW_GetWindowInfo), by the way.
You need to log in before you can comment on or make changes to this bug.