Remove support for DDE integration in toolkit

RESOLVED FIXED in Firefox 67

Status

()

defect
RESOLVED FIXED
10 years ago
3 months ago

People

(Reporter: jimm, Assigned: mossop)

Tracking

(Depends on 1 bug, Blocks 1 bug)

Trunk
mozilla67
x86
Windows Vista
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(2 attachments)

Reporter

Description

10 years ago
Investigate whether or not DDE related code should be removed once the patch in bug 491947 lands.
Reporter

Comment 1

10 years ago
Reporter

Comment 2

10 years ago
Overall this appears to be working fine. I'll be doing some additional testing and will also post try builds. 

The one (minor?) issue with removing support for DDE is that when a mozilla app is launched as a handler, (start->run uri, double click on a shortcut, click on a link in mail to open the browser, etc.) rather than receiving dde messages from windows a second instance is launched, which then hands the request to the running instance. On the plus side, we get rid of DDE which has been an endless series of headaches ever since it was implemented. There are currently a number of open bugs related to dde for Fx, some of which are fairly critical for new win7 features.

Bug 491947 involves disabling DDE in Fx, this bug relates to removing our support for it in platform.
Seamonkey people will need to be notified of this change.
Reporter

Updated

10 years ago
Summary: Remove obsolete dde integration code in nsNativeAppSupportWin → Remove support for DDE integration in toolkit
Actually, it appears that pref is no longer used. I'll remove it in bug 491947.
Depends on: 739890
Reporter

Updated

5 years ago
Assignee: jmathies → nobody

Updated

2 years ago
Blocks: 1373212
Assignee

Comment 6

5 months ago

Any reason I can't complete this Jim? It is making some other changes I'm making more painful.

Flags: needinfo?(jmathies)
Reporter

Comment 7

5 months ago

(In reply to Dave Townsend [:mossop] (he/him) from comment #6)

Any reason I can't complete this Jim? It is making some other changes I'm
making more painful.

sounds good to me!

Flags: needinfo?(jmathies)

Comment 9

3 months ago
Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ef3cc37f719
Remove support for DDE from toolkit. r=jimm

Backed out 11 changesets (bug 1518639, bug 513742) for chrome failures at browser/components/shell/test/test_headless_screenshot.html

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/3d8dd3615c4589c9cafe613a471152323078b5d9

Failure push: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&selectedJob=232210960&revision=84e8066625fd72fdb1eb6eab85621ae842fe91b4

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=232210960&repo=mozilla-inbound&lineNumber=1926

18:20:33 INFO - TEST-PASS | browser/components/shell/test/test_headless_screenshot.html | Firefox process should exit with code 0
18:20:33 INFO - Buffered messages finished
18:20:33 INFO - TEST-UNEXPECTED-FAIL | browser/components/shell/test/test_headless_screenshot.html | A screenshot should be saved as /var/folders/41/j2frw4wn0l95_gy85cqjt9_400000w/T/headless_test_screenshot.png
18:20:33 INFO - SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:275:18
18:20:33 INFO - testFileCreationPositive@chrome://mochitests/content/chrome/browser/components/shell/test/test_headless_screenshot.html:55:5
18:20:33 INFO - async*@chrome://mochitests/content/chrome/browser/components/shell/test/test_headless_screenshot.html:112:11
18:20:33 INFO - @chrome://mochitests/content/chrome/browser/components/shell/test/test_headless_screenshot.html:141:5
18:20:33 INFO - GECKO(1989) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /var/folders/41/j2frw4wn0l95_gy85cqjt9_400000w/T/tmpFSV0M8.mozrunner/runtests_leaks.log
18:20:35 INFO - GECKO(1989) | --DOMWINDOW == 32 (0x1259a3000) [pid = 1989] [serial = 10] [outer = 0x0] [url = about:blank]
18:20:35 INFO - GECKO(1989) | --DOMWINDOW == 31 (0x1259a3c00) [pid = 1989] [serial = 12] [outer = 0x0] [url = about:blank]
18:20:35 INFO - GECKO(1989) | --DOMWINDOW == 30 (0x1259a4c00) [pid = 1989] [serial = 14] [outer = 0x0] [url = about:blank]
18:20:35 INFO - GECKO(1989) | --DOMWINDOW == 29 (0x1259a5c00) [pid = 1989] [serial = 16] [outer = 0x0] [url = about:blank]
18:20:35 INFO - GECKO(1989) | --DOMWINDOW == 28 (0x1259a6c00) [pid = 1989] [serial = 18] [outer = 0x0] [url = about:blank]
18:20:35 INFO - GECKO(1989) | --DOMWINDOW == 27 (0x12750d400) [pid = 1989] [serial = 26] [outer = 0x0] [url = about:blank]
18:20:35 INFO - GECKO(1989) | --DOMWINDOW == 26 (0x1279d2c00) [pid = 1989] [serial = 27] [outer = 0x0] [url = about:blank]
18:20:35 INFO - GECKO(1989) | --DOMWINDOW == 25 (0x1254c1000) [pid = 1989] [serial = 7] [outer = 0x0] [url = about:blank]
18:20:35 INFO - GECKO(1989) | --DOMWINDOW == 24 (0x12b7cf400) [pid = 1989] [serial = 31] [outer = 0x0] [url = about:blank]
18:20:35 INFO - GECKO(1989) | --DOMWINDOW == 23 (0x12b7ce800) [pid = 1989] [serial = 32] [outer = 0x0] [url = about:blank]
18:20:35 INFO - GECKO(1989) | >>> 1551896435222 addons.webextension.screenshots@mozilla.org WARN Loading extension 'screenshots@mozilla.org': Reading manifest: Invalid extension permission: mozillaAddons
18:20:35 INFO - GECKO(1989) | >>> 1551896435224 addons.webextension.screenshots@mozilla.org WARN Loading extension 'screenshots@mozilla.org': Reading manifest: Invalid extension permission: resource://pdf.js/
18:20:35 INFO - GECKO(1989) | 1551896435224 addons.webextension.screenshots@mozilla.org WARN Loading extension 'screenshots@mozilla.org': Reading manifest: Invalid extension permission: about:reader*
18:20:35 INFO - GECKO(1989) | [1996, Main Thread] WARNING: 'NS_FAILED(rv)', file /builds/worker/workspace/build/src/dom/presentation/provider/MulticastDNSDeviceProvider.cpp, line 125
18:20:35 INFO - GECKO(1989) | [1996, Main Thread] WARNING: 'NS_FAILED(rv = Init())', file /builds/worker/workspace/build/src/dom/presentation/provider/MulticastDNSDeviceProvider.cpp, line 574
18:20:35 INFO - GECKO(1989) | >>> 1551896435767 Marionette TRACE Received observer notification profile-after-change
18:20:35 INFO - GECKO(1989) | ++DOCSHELL 0x1192a6800 == 1 [pid = 1996] [id = {f9fbdaa5-a792-d645-976c-fd19aff3ecb9}]
18:20:35 INFO - GECKO(1989) | ++DOMWINDOW == 1 (0x10f8c7980) [pid = 1996] [serial = 1] [outer = 0x0]
18:20:35 INFO - GECKO(1989) | >>> 1551896435860 Marionette TRACE Received observer notification command-line-startup
18:20:35 INFO - GECKO(1989) | ++DOMWINDOW == 2 (0x119248c00) [pid = 1996] [serial = 2] [outer = 0x10f8c7980]
18:20:35 INFO - GECKO(1989) | [1996, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file /builds/worker/workspace/build/src/extensions/cookie/nsPermissionManager.cpp, line 2887
18:20:36 INFO - GECKO(1989) | [1996, Main Thread] ###!!! ASSERTION: consider quit stopper out of bounds: 'mConsiderQuitStopper > 0', file /builds/worker/workspace/build/src/toolkit/components/startup/nsAppStartup.cpp, line 501
18:20:36 INFO - GECKO(1989) | >>> expected exactly one URL when using screenshot
18:20:36 INFO - GECKO(1989) | JavaScript error: resource:///modules/aboutpages/AboutPrivateBrowsingHandler.jsm, line 28: TypeError: this.pageListener is undefined
18:20:36 INFO - GECKO(1989) | ++DOCSHELL 0x10e512800 == 2 [pid = 1996] [id = {b2199ba3-3cc2-e64d-897e-c43bcc6103d7}]
18:20:36 INFO - GECKO(1989) | ++DOMWINDOW == 3 (0x10f8c7b60) [pid = 1996] [serial = 3] [outer = 0x0]
18:20:36 INFO - GECKO(1989) | ++DOMWINDOW == 4 (0x119ada000) [pid = 1996] [serial = 4] [outer = 0x10f8c7b60]
18:20:36 INFO - GECKO(1989) | ++DOMWINDOW == 5 (0x119adc400) [pid = 1996] [serial = 5] [outer = 0x10f8c7b60]
18:20:36 INFO - GECKO(1989) | ++DOCSHELL 0x121590000 == 3 [pid = 1996] [id = {e0054e70-cd50-b542-9f94-fb1290cee745}]
18:20:36 INFO - GECKO(1989) | ++DOMWINDOW == 6 (0x1215e6020) [pid = 1996] [serial = 6] [outer = 0x0]
18:20:36 INFO - GECKO(1989) | ++DOMWINDOW == 7 (0x1215c8000) [pid = 1996] [serial = 7] [outer = 0x1215e6020]
18:20:36 INFO - GECKO(1989) | ++DOCSHELL 0x121592000 == 4 [pid = 1996] [id = {fe1e96fd-dc4c-fa4a-a8a0-2e5d10bd4729}]
18:20:36 INFO - GECKO(1989) | ++DOMWINDOW == 8 (0x1215e7880) [pid = 1996] [serial = 8] [outer = 0x0]
18:20:36 INFO - GECKO(1989) | ++DOMWINDOW == 9 (0x1215c9400) [pid = 1996] [serial = 9] [outer = 0x1215e7880]
18:20:36 INFO - GECKO(1989) | ++DOCSHELL 0x121594000 == 5 [pid = 1996] [id = {96b21b7f-ecc3-dd45-bdb5-b82382d2ba36}]
18:20:36 INFO - GECKO(1989) | ++DOMWINDOW == 10 (0x1215e7e20) [pid = 1996] [serial = 10] [outer = 0x0]

Flags: needinfo?(dtownsend)

Comment 11

3 months ago
Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/61ed2a079848
Remove support for DDE from toolkit. r=jimm

Comment 12

3 months ago
bugherder
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Assignee: nobody → dtownsend
Assignee

Updated

3 months ago
Flags: needinfo?(dtownsend)
You need to log in before you can comment on or make changes to this bug.