1373349 - Make layout/reftests/async-scrolling/bg-fixed-child-no-culling-3.html pass on linux64-qr with APZ enabled

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

With WR+APZ enabled, the layout/reftests/async-scrolling/bg-fixed-child-no-culling-3.html reftest fails. This bug is for the patches that make it pass, without regressing any "earlier" tests.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

My initial investigation indicates that we're not sending the right stuff to WR for this case because the scrollframe is overflow:hidden and we treat that a bit specially [1]. In particular the scrollable rect (which is passed as the content_rect to the scrolling clip) has a nonzero origin which doesn't quite map properly.

[1] http://searchfox.org/mozilla-central/rev/c49a70b53f67dd5550eec8a08793805f2aca8d42/layout/base/nsLayoutUtils.cpp#8421,8425

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Fix was pretty simple. Try pushes with and without APZ:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a50b384c62ac5fcf19772081e3fa46c2d8e619ab
https://treeherder.mozilla.org/#/jobs?repo=try&revision=73a1fa633328215e8a731255b8733e5bea710a3e

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1373349 - Correct the origin of the content rect when creating scroll layers in WR.

Also tweaks the documentation in FrameMetrics.h to be more detailed and
less misleading.

Review commit: https://reviewboard.mozilla.org/r/149548/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/149548/

Comment 4

[Kartikaya Gupta (email:[e-mail])]

This one actually fixes a slew of APZ-enabled reftest failures. The number of reftest failures goes down from 42 (without this patch) to 24 (with the patch). \o/

Comment 5

[Botond Ballo [:botond]]

Comment on attachment 8878169 [details]
Bug 1373349 - Correct the origin of the content rect when creating scroll layers in WR.

https://reviewboard.mozilla.org/r/149548/#review154616

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8878169 [details]
Bug 1373349 - Correct the origin of the content rect when creating scroll layers in WR.

https://reviewboard.mozilla.org/r/149548/#review155266

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc1eba30064a
Correct the origin of the content rect when creating scroll layers in WR. r=botond,jrmuizel

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dc1eba30064a