Closed Bug 1373349 Opened 4 years ago Closed 4 years ago

Make layout/reftests/async-scrolling/bg-fixed-child-no-culling-3.html pass on linux64-qr with APZ enabled

Categories

(Core :: Graphics: WebRender, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

With WR+APZ enabled, the layout/reftests/async-scrolling/bg-fixed-child-no-culling-3.html reftest fails. This bug is for the patches that make it pass, without regressing any "earlier" tests.
My initial investigation indicates that we're not sending the right stuff to WR for this case because the scrollframe is overflow:hidden and we treat that a bit specially [1]. In particular the scrollable rect (which is passed as the content_rect to the scrolling clip) has a nonzero origin which doesn't quite map properly.

[1] http://searchfox.org/mozilla-central/rev/c49a70b53f67dd5550eec8a08793805f2aca8d42/layout/base/nsLayoutUtils.cpp#8421,8425
This one actually fixes a slew of APZ-enabled reftest failures. The number of reftest failures goes down from 42 (without this patch) to 24 (with the patch). \o/
Comment on attachment 8878169 [details]
Bug 1373349 - Correct the origin of the content rect when creating scroll layers in WR.

https://reviewboard.mozilla.org/r/149548/#review154616
Attachment #8878169 - Flags: review?(botond) → review+
Comment on attachment 8878169 [details]
Bug 1373349 - Correct the origin of the content rect when creating scroll layers in WR.

https://reviewboard.mozilla.org/r/149548/#review155266
Attachment #8878169 - Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dc1eba30064a
Correct the origin of the content rect when creating scroll layers in WR. r=botond,jrmuizel
https://hg.mozilla.org/mozilla-central/rev/dc1eba30064a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.