Closed
Bug 1373374
Opened 7 years ago
Closed 7 years ago
SeaMonkey is incorrectly enclosed in quotation marks in Set Default Programs dialog
Categories
(SeaMonkey :: Installer, defect)
Tracking
(seamonkey2.48 wontfix, seamonkey2.49esr fixed, seamonkey2.50 wontfix, seamonkey2.51 wontfix, seamonkey2.52 wontfix, seamonkey2.54 fixed, seamonkey2.55 fixed, seamonkey2.53 fixed)
People
(Reporter: frg, Assigned: frg)
Details
(Whiteboard: SM2.53.1)
Attachments
(2 files, 2 obsolete files)
23.07 KB,
image/png
|
Details | |
1000 bytes,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-beta+
iannbugzilla
:
approval-comm-release+
iannbugzilla
:
approval-comm-esr52+
|
Details | Diff | Splinter Review |
Tile says it all. SeaMonkey (Mail) and SeaMonkey (News) are not affected.
Assignee | ||
Comment 1•7 years ago
|
||
picture showing the problem.
Assignee | ||
Comment 2•7 years ago
|
||
SeaMonkey currently is the only product defining them in moz.build so align the installers with TB and IB.
Attachment #8878185 -
Flags: review?(rsx11m.pub)
Comment 3•7 years ago
|
||
REPRODUCIBLE with Installation of unofficial (by FRG) DE SeaMonkey 2.49.1 (NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 Build 20170511042150 (Default Classic Theme) on German WIN7 64bit, I see those single quotation marks around SeaMonkey. But I can't tell which installation caused this mistake.
Assignee | ||
Comment 4•7 years ago
|
||
> But I can't tell which installation caused this mistake. Must have been so for ages in moz.build. See "'%s'" in > DEFINES['MOZ_APP_DISPLAYNAME'] = "'%s'" % CONFIG['MOZ_APP_DISPLAYNAME']
Assignee | ||
Updated•7 years ago
|
Attachment #8878185 -
Flags: review?(rsx11m.pub) → review?(iann_bugzilla)
Comment on attachment 8878185 [details] [diff] [review] 1373374-quotationmarks.patch The correct thing to do would be to port Bug 1225918 - avoid quoting MOZ_APP_DISPLAYNAME when used as a DEFINE
Attachment #8878185 -
Flags: review?(iann_bugzilla) → review-
Assignee | ||
Comment 6•7 years ago
|
||
Made the patch simpler :)
Attachment #8878185 -
Attachment is obsolete: true
Assignee | ||
Comment 7•7 years ago
|
||
Comment adjusted. Tested and working. [Approval Request Comment] Regression caused by (bug #): -- User impact if declined: cosmetic Testing completed (on m-c, etc.):c-b Risk to taking this patch (and alternatives if risky): low/no risk String changes made by this patch: none
Attachment #8904074 -
Attachment is obsolete: true
Attachment #8904143 -
Flags: review?(iann_bugzilla)
Attachment #8904143 -
Flags: approval-comm-release?
Attachment #8904143 -
Flags: approval-comm-esr52?
Attachment #8904143 -
Flags: approval-comm-beta?
Comment on attachment 8904143 [details] [diff] [review] 1373374-quotationmarks-V2.patch r/a=me
Attachment #8904143 -
Flags: review?(iann_bugzilla)
Attachment #8904143 -
Flags: review+
Attachment #8904143 -
Flags: approval-comm-release?
Attachment #8904143 -
Flags: approval-comm-release+
Attachment #8904143 -
Flags: approval-comm-esr52?
Attachment #8904143 -
Flags: approval-comm-esr52+
Attachment #8904143 -
Flags: approval-comm-beta?
Attachment #8904143 -
Flags: approval-comm-beta+
Pushed by frgrahl@gmx.net: https://hg.mozilla.org/comm-central/rev/4415a4c2c949 Remove single quotation marks around MOZ_APP_DISPLAYNAME in SeaMonkey installer. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 10•7 years ago
|
||
https://hg.mozilla.org/releases/comm-beta/rev/2780c09c0ddab2d1ef566cf9cf557749fe97001f https://hg.mozilla.org/releases/comm-release/rev/e11263ef16ac1501a7f051639fedf1a0d00d3392 https://hg.mozilla.org/releases/comm-esr52/rev/d13dc1220627904c7b6d3b7d17b8adf7519529d5
status-seamonkey2.53:
--- → fixed
status-seamonkey2.54:
--- → fixed
status-seamonkey2.55:
--- → fixed
Target Milestone: --- → seamonkey2.55
You need to log in
before you can comment on or make changes to this bug.
Description
•