1373486 - --disable-compile-environment builds are still somehow invoking gyp

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Got this on try for a build with --disable-compile-environment:

18:49:35     INFO -   0:16.79 Traceback (most recent call last):
18:49:35     INFO -   0:16.79   File "/builds/slave/try-lx-l10n-000000000000000000/build/try/configure.py", line 124, in <module>
18:49:35     INFO -   0:16.79     sys.exit(main(sys.argv))
18:49:35     INFO -   0:16.79   File "/builds/slave/try-lx-l10n-000000000000000000/build/try/configure.py", line 34, in main
18:49:35     INFO -   0:16.79     return config_status(config)
18:49:35     INFO -   0:16.79   File "/builds/slave/try-lx-l10n-000000000000000000/build/try/configure.py", line 119, in config_status
18:49:35     INFO -   0:16.79     return config_status(args=[], **encode(sanitized_config, encoding))
18:49:35     INFO -   0:16.79   File "/builds/slave/try-lx-l10n-000000000000000000/build/try/python/mozbuild/mozbuild/config_status.py", line 147, in config_status
18:49:35     INFO -   0:16.79     definitions = list(definitions)
18:49:35     INFO -   0:16.79   File "/builds/slave/try-lx-l10n-000000000000000000/build/try/python/mozbuild/mozbuild/frontend/emitter.py", line 170, in emit
18:49:35     INFO -   0:16.79     for out in output:
18:49:35     INFO -   0:16.79   File "/builds/slave/try-lx-l10n-000000000000000000/build/try/python/mozbuild/mozbuild/frontend/reader.py", line 894, in read_topsrcdir
18:49:35     INFO -   0:16.79     for gyp_context in g.results:
18:49:35     INFO -   0:16.79   File "/builds/slave/try-lx-l10n-000000000000000000/build/try/python/mozbuild/mozbuild/frontend/gyp_reader.py", line 411, in results
18:49:35     INFO -   0:16.79     flat_list, targets, data = self._gyp_loader_future.result()
18:49:35     INFO -   0:16.79   File "/builds/slave/try-lx-l10n-000000000000000000/build/try/third_party/python/futures/concurrent/futures/_base.py", line 398, in result
18:49:35     INFO -   0:16.79     return self.__get_result()
18:49:35     INFO -   0:16.79   File "/builds/slave/try-lx-l10n-000000000000000000/build/try/third_party/python/futures/concurrent/futures/_base.py", line 357, in __get_result
18:49:35     INFO -   0:16.79     raise type(self._exception), self._exception, self._traceback
18:49:35     INFO -   0:16.79 gyp.common.GypError: Call to 'pkg-config --cflags gobject-2.0 gthread-2.0 gtk+-2.0' returned exit status 1 while in /builds/slave/try-lx-l10n-000000000000000000/build/try/media/webrtc/trunk/webrtc/media/media.gyp. while loading dependencies of /builds/slave/try-lx-l10n-000000000000000000/build/try/media/webrtc/trunk/webrtc/api/api.gyp while loading dependencies of /builds/slave/try-lx-l10n-000000000000000000/build/try/media/webrtc/trunk/webrtc/webrtc.gyp while loading dependencies of /builds/slave/try-lx-l10n-000000000000000000/build/try/media/webrtc/trunk/peerconnection.gyp while trying to load /builds/slave/try-lx-l10n-000000000000000000/build/try/media/webrtc/trunk/peerconnection.gyp
18:49:35     INFO -   0:17.03 *** Fix above errors and then restart with\
18:49:35     INFO -   0:17.03                "/usr/bin/gmake -f client.mk build"
18:49:35     INFO -   0:17.03 gmake: *** [configure] Error 1

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1373486 - Skip gyp directories when building without a compile environment.

security/ is already skipped through top-level moz.build. For
convenience, we skip the DIRS that end up adding GYP_DIRS, avoiding
reindenting their entire moz.build.

Review commit: https://reviewboard.mozilla.org/r/149616/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/149616/

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8878289 [details]
Bug 1373486 - Skip gyp directories when building without a compile environment.

https://reviewboard.mozilla.org/r/149616/#review154540

Would it help if we just skipped all GYP_DIRS in reader.py instead of handling it in individual moz.build files?

Comment 3

[Mike Hommey [:glandium]]

I didn't want to enforce such logic in the frontend, because of hypothetical non-compilation files in gyp definitions that we'd want built.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e32d7bb6a79e
Skip gyp directories when building without a compile environment. r=mshal

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e32d7bb6a79e