Closed Bug 1373150 Opened 2 years ago Closed 2 years ago

Disable compile environment on l10n builds

Categories

(Release Engineering :: General, enhancement, P1)

enhancement

Tracking

(firefox56 fixed)

RESOLVED FIXED
Tracking Status
firefox56 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

In preparation for the after-bug 1313111 life where I want to start removing things from tooltool manifests, l10n jobs expecting to pull things from there (and not yet being on TC so being able to get the TC toolchain artifacts) are making things more difficult than necessary.

As it turns out, l10n builds are essentially artifact builds. They shouldn't need a toolchain. In fact, they probably only do for nsinstall (which is why they run make export in config/), but the build system can work without nsinstall.

I did a try build with --disable-compile-environment, and the l10n build that was triggered there (arguably on TC) was strill green.

So let's see if l10n buildbot builds bust if we do the same.
Comment on attachment 8877885 [details]
Bug 1373150 - Disable compile environment on l10n builds.

https://reviewboard.mozilla.org/r/149314/#review154074

from the try run: https://treeherder.mozilla.org/logviewer.html#?job_id=107394380&repo=try&lineNumber=6332 --  failed configure on windows.
Attachment #8877885 - Flags: review?(bugspam.Callek) → review-
Priority: -- → P1
(In reply to Justin Wood (:Callek) from comment #2)
> Comment on attachment 8877885 [details]
> Bug 1373150 - Disable compile environment on l10n builds.
> 
> https://reviewboard.mozilla.org/r/149314/#review154074
> 
> from the try run:
> https://treeherder.mozilla.org/logviewer.
> html#?job_id=107394380&repo=try&lineNumber=6332 --  failed configure on
> windows.

Log is unavailable...
Flags: needinfo?(bugspam.Callek)
Depends on: 1373486
Note about the try associated with the review:
- The busted SM builds are perma busted for other reasons and aren't even running on m-c/inbound/etc.
- The Linux opt l10n(l10n) build is busted because of bug 1373486 ; here's another try with the patch from that bug applied: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b6d8d358af0f13d45f501f2f5e584d30cdb4353 where it fails for a different reason (see below)
- The Linux x64 opt l10n(l10n) build is busted because it tries to download http://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central/target.tar.bz2, which doesn't exist, and that's related to EN_US_PACKAGE_NAME being set to target.tar.bz2 and en_us_binary_url to http://archive.mozilla.org/pub/firefox/nightly/latest-mozilla-central, neither of which is my due.
And it looks like the osx and windows builds are busted because of things like:
20:09:45  WARNING - Timed out accessing http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central/mar-tools/macosx64/mar: timed out

which seem unrelated too.
Comment on attachment 8877885 [details]
Bug 1373150 - Disable compile environment on l10n builds.

https://reviewboard.mozilla.org/r/149314/#review154498

Can you make sure a followup is on file about tooltool manifests for l10n jobs. Specifically many mozharness runs download a bunch of tooltool things to support compiling, (e.g. windows does msvc), with this patch its not needed.

I should note that your toolchain support could eliminate some of the pain there, but even ahead of that the tooltool cleanup(s) could benefit us in end to end.

::: build/mozconfig.no-compile:11
(Diff revision 6)
> +unset HOST_CC
> +unset HOST_CXX
> +unset RUSTC
> +unset CARGO
> +unset MAKECAB
> +unset TOOLCHAIN_PREFIX

I'm less confident on why we need (or should need) the `unset`'s here, since imho that means --disable-compile-environment doesn't properly block that stuff from "doing things" even in a local environment where those values are defined.

That said, I'm no expert on what they are needed for, and in practice our mozconfigs are "for automation" not local dev so, not blocking.
Attachment #8877885 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 8877885 [details]
Bug 1373150 - Disable compile environment on l10n builds.

https://reviewboard.mozilla.org/r/149314/#review154500

Additionally, I am *slightly* concerned with the windows results, but I do think its merely a case of "too big locales lists break on Buildbot based try l10n jobs..."  (the linux BB l10n, I'm not worried about)

Given that can you do a new try push before landing, with a *much* reduced https://dxr.mozilla.org/mozilla-central/source/browser/locales/all-locales -- specifically languages of `ru, ja{,-jp-mac},fr,en-GB,zh-TW}` will be plenty enough for my purposes
(In reply to Justin Wood (:Callek) from comment #12)
> ::: build/mozconfig.no-compile:11
> (Diff revision 6)
> > +unset HOST_CC
> > +unset HOST_CXX
> > +unset RUSTC
> > +unset CARGO
> > +unset MAKECAB
> > +unset TOOLCHAIN_PREFIX
> 
> I'm less confident on why we need (or should need) the `unset`'s here, since
> imho that means --disable-compile-environment doesn't properly block that
> stuff from "doing things" even in a local environment where those values are
> defined.

Actually, configure rejects them being set. And mozconfigs are a mess, it's easier to unset them.
(In reply to Justin Wood (:Callek) from comment #12)
> Comment on attachment 8877885 [details]
> Bug 1373150 - Disable compile environment on l10n builds.
> 
> https://reviewboard.mozilla.org/r/149314/#review154498
> 
> Can you make sure a followup is on file about tooltool manifests for l10n
> jobs. Specifically many mozharness runs download a bunch of tooltool things
> to support compiling, (e.g. windows does msvc), with this patch its not
> needed.

I'll do that once it's confirmed this sticks.
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/943dc0fef263
Disable compile environment on l10n builds. r=Callek
https://hg.mozilla.org/mozilla-central/rev/943dc0fef263
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.