1373563 - Mozscreenshots: intermittent controlCenter_localFile on Windows 10

Status: RESOLVED FIXED

(Testing :: mozscreenshots, enhancement, P3)

Description

[Johann Hofmann [:johannh]]

Our Windows 10 machines are using temporary task_* paths for builds, which means we get comparisons like this:

https://screenshots.mattn.ca/comparisons/mozilla-central/c8f3df191e354062025352a45ac421e557ed324c/mozilla-central/a8f8e440d627d686fa8898483aa9c5da928a8fa4/windows10-64-vm/controlCenter_02_noLWT_localFile.png

I think we can live without the local file screenshot on Windows 10 (it's not an important screenshot test in general, IMO).

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1373563 - Mozscreenshots: disable intermittent controlCenter_localFile on Windows 10 and OSX.

I'm not sure whether this problem will extend to Linux and Win < 10
any time soon, if that's the case we will need to disable the test
entirely.

Review commit: https://reviewboard.mozilla.org/r/158762/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158762/

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8887845 [details]
Bug 1373563 - Mozscreenshots: disable intermittent controlCenter_localFile on Windows 10 and OSX.

https://reviewboard.mozilla.org/r/158762/#review168586

::: browser/tools/mozscreenshots/mozscreenshots/extension/configurations/ControlCenter.jsm:211
(Diff revision 1)
> +// Local file paths include temporary task identifiers on OSX and Win10.
> +if (AppConstants.platform != "macosx" &&
> +    !AppConstants.isPlatformAndVersionAtLeast("win", "10")) {
> +  this.ControlCenter.localFile = async function applyConfig() {
> +      let channel = NetUtil.newChannel({

This isn't the best way to skip a screenshot, instead you should implement the `validateConfig` method and leave it in the same order so the combination number stays consistent across OSs. This issue will affect all TC jobs and I want to shut BB ones off soon so I think we should fix the test (e.g. point to a different dir which is consistent)

Comment 3

[Matthew N. [:MattN]]

I'll put a short-term verifyConfig in for now to avoid the noise.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2691dd1e7db4
Skip the ControlCenter localFile mozscreenshots configuration due to changing paths. r=me

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2691dd1e7db4

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Assigning to Chris to try to address the intermittent and re-enable.

Comment 7

[Matthew N. [:MattN]]

Attachment: Bug 1373563 - Skip the content blocking intro in mozscreenshots for ControlCenter images. r?johannh

Comment 8

[Matthew N. [:MattN]]

Attachment: Bug 1373563 - More specific mozscreenshots cropping for PermissionPrompts and ControlCenter. r?johannh

Depends on D8814

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30a7005f36e4
Skip the content blocking intro in mozscreenshots for ControlCenter images. r=johannh

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/30a7005f36e4

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c7087c21750
More specific mozscreenshots cropping for PermissionPrompts and ControlCenter. r=johannh

Comment 12

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9c7087c21750