Closed Bug 1373563 Opened 3 years ago Closed Last year

Mozscreenshots: intermittent controlCenter_localFile on Windows 10

Categories

(Testing :: mozscreenshots, enhancement, P3)

enhancement

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: johannh, Assigned: MattN)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Our Windows 10 machines are using temporary task_* paths for builds, which means we get comparisons like this:

https://screenshots.mattn.ca/comparisons/mozilla-central/c8f3df191e354062025352a45ac421e557ed324c/mozilla-central/a8f8e440d627d686fa8898483aa9c5da928a8fa4/windows10-64-vm/controlCenter_02_noLWT_localFile.png

I think we can live without the local file screenshot on Windows 10 (it's not an important screenshot test in general, IMO).
Component: General → mozscreenshots
Priority: -- → P3
Product: Firefox → Testing
Comment on attachment 8887845 [details]
Bug 1373563 - Mozscreenshots: disable intermittent controlCenter_localFile on Windows 10 and OSX.

https://reviewboard.mozilla.org/r/158762/#review168586

::: browser/tools/mozscreenshots/mozscreenshots/extension/configurations/ControlCenter.jsm:211
(Diff revision 1)
> +// Local file paths include temporary task identifiers on OSX and Win10.
> +if (AppConstants.platform != "macosx" &&
> +    !AppConstants.isPlatformAndVersionAtLeast("win", "10")) {
> +  this.ControlCenter.localFile = async function applyConfig() {
> +      let channel = NetUtil.newChannel({

This isn't the best way to skip a screenshot, instead you should implement the `validateConfig` method and leave it in the same order so the combination number stays consistent across OSs. This issue will affect all TC jobs and I want to shut BB ones off soon so I think we should fix the test (e.g. point to a different dir which is consistent)
Attachment #8887845 - Flags: review?(MattN+bmo)
I'll put a short-term verifyConfig in for now to avoid the noise.
Keywords: leave-open
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2691dd1e7db4
Skip the ControlCenter localFile mozscreenshots configuration due to changing paths. r=me
Assigning to Chris to try to address the intermittent and re-enable.
Assignee: jhofmann → chochri5
Assignee: chochri5 → MattN+bmo
Mentor: jaws, mconley
Keywords: leave-open
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/30a7005f36e4
Skip the content blocking intro in mozscreenshots for ControlCenter images. r=johannh
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c7087c21750
More specific mozscreenshots cropping for PermissionPrompts and ControlCenter. r=johannh
https://hg.mozilla.org/mozilla-central/rev/9c7087c21750
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.