1373823 - Fix about:telemetry data preferences change button (uplift to beta55)

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[flyingrub]

Clicking on the links in about:telemetry in Beta55 is broken, because of the recent changes in the preferences layout. We should fix Beta55 before it becomes Release55.

Comment 1

[Georg Fritzsche [:gfritzsche]]

If you want to fix issues on beta, you should aim to do it as early as possible.
The later we are into the beta cycle the less risk we want to take with code uplifts.

Comment 2

[flyingrub]

Attachment: Bug 1373823 - Fix about:telemetry data preferences change button in beta55

Review commit: https://reviewboard.mozilla.org/r/151340/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151340/

Comment 3

[Chris H-C :chutten]

Comment on attachment 8880007 [details]
Bug 1373823 - Fix about:telemetry data preferences change button in beta55

https://reviewboard.mozilla.org/r/151340/#review156280

::: toolkit/content/aboutTelemetry.js:239
(Diff revision 1)
>              resource: "preferences_privacy",
>            });
>          } else {
>            // Show the data choices preferences on desktop.
>            let mainWindow = getMainWindowWithPreferencesPane();
> -          mainWindow.openPreferences("privacy-reports", {origin: "aboutTelemetry"});
> +          mainWindow.openAdvancedPreferences("dataChoicesTab", {origin: "aboutTelemetry"});

I think this should be reverted to be similar to what it used to be. If useOldOrganization is true (as it is for beta55) then it should be #advanced/dataChoicesTab

If useOldOrganization is false, then it should be #privacy

I think the original code that added the useOldOrganization check pointed to the wrong place in the new organization which caused all this confusion in the first place.

Comment 4

[flyingrub]

Comment on attachment 8880007 [details]
Bug 1373823 - Fix about:telemetry data preferences change button in beta55

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151340/diff/1-2/

Comment 5

[Chris H-C :chutten]

Comment on attachment 8880007 [details]
Bug 1373823 - Fix about:telemetry data preferences change button in beta55

https://reviewboard.mozilla.org/r/151340/#review156722

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc59646d36a4
Fix about:telemetry data preferences change button in beta55 r=chutten

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dc59646d36a4

Comment 8

[flyingrub]

Comment on attachment 8880007 [details]
Bug 1373823 - Fix about:telemetry data preferences change button in beta55

Approval Request Comment
[Feature/Bug causing the regression]:
    Bug 1373823

[User impact if declined]:
    Clicking on the data preferences change button will not redirect to the correct section.

[Is this code covered by automated tests?]: No

[Has the fix been verified in Nightly?]: Yes

[Needs manual test from QE? If yes, steps to reproduce]: 
    1) Open about:telemetry
    2) Click on any of the "change" links.
    The preference section is not the right one (Advanced > Data Choices)

[List of other uplifts needed for the feature/fix]: None

[Is the change risky?]: No

[Why is the change risky/not risky?]:
    It only correct the displayed section in the preference when clicking on the button.

[String changes made/needed]: None

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 8880007 [details]
Bug 1373823 - Fix about:telemetry data preferences change button in beta55

fix link to preferences in about:telemetry, beta55+

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ed35720fd07c

Comment 11

[Rezaul Huque Nayeem]

Successfully Reproduced the bug in Nightly 56.0a1 (2017-06-16) on windows 10 x64

Verified as fixed with latest Firefox Beta 56.0b2 (Build ID: 20170810180547) 

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0