Fix about:telemetry data preferences change button (uplift to beta55)

RESOLVED FIXED in Firefox 55

Status

()

P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: flyingrub, Assigned: flyingrub)

Tracking

(Blocks: 1 bug)

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed, firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Clicking on the links in about:telemetry in Beta55 is broken, because of the recent changes in the preferences layout. We should fix Beta55 before it becomes Release55.
If you want to fix issues on beta, you should aim to do it as early as possible.
The later we are into the beta cycle the less risk we want to take with code uplifts.
Priority: -- → P1
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Assignee: nobody → flyinggrub

Comment 3

a year ago
mozreview-review
Comment on attachment 8880007 [details]
Bug 1373823 - Fix about:telemetry data preferences change button in beta55

https://reviewboard.mozilla.org/r/151340/#review156280

::: toolkit/content/aboutTelemetry.js:239
(Diff revision 1)
>              resource: "preferences_privacy",
>            });
>          } else {
>            // Show the data choices preferences on desktop.
>            let mainWindow = getMainWindowWithPreferencesPane();
> -          mainWindow.openPreferences("privacy-reports", {origin: "aboutTelemetry"});
> +          mainWindow.openAdvancedPreferences("dataChoicesTab", {origin: "aboutTelemetry"});

I think this should be reverted to be similar to what it used to be. If useOldOrganization is true (as it is for beta55) then it should be #advanced/dataChoicesTab

If useOldOrganization is false, then it should be #privacy

I think the original code that added the useOldOrganization check pointed to the wrong place in the new organization which caused all this confusion in the first place.
Attachment #8880007 - Flags: review?(chutten) → review-
Comment hidden (mozreview-request)

Comment 5

a year ago
mozreview-review
Comment on attachment 8880007 [details]
Bug 1373823 - Fix about:telemetry data preferences change button in beta55

https://reviewboard.mozilla.org/r/151340/#review156722
Attachment #8880007 - Flags: review?(chutten) → review+

Comment 6

a year ago
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dc59646d36a4
Fix about:telemetry data preferences change button in beta55 r=chutten

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/dc59646d36a4
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
(Assignee)

Comment 8

a year ago
Comment on attachment 8880007 [details]
Bug 1373823 - Fix about:telemetry data preferences change button in beta55

Approval Request Comment
[Feature/Bug causing the regression]:
    Bug 1373823

[User impact if declined]:
    Clicking on the data preferences change button will not redirect to the correct section.

[Is this code covered by automated tests?]: No

[Has the fix been verified in Nightly?]: Yes

[Needs manual test from QE? If yes, steps to reproduce]: 
    1) Open about:telemetry
    2) Click on any of the "change" links.
    The preference section is not the right one (Advanced > Data Choices)

[List of other uplifts needed for the feature/fix]: None

[Is the change risky?]: No

[Why is the change risky/not risky?]:
    It only correct the displayed section in the preference when clicking on the button.

[String changes made/needed]: None
Attachment #8880007 - Flags: approval-mozilla-beta?
Comment on attachment 8880007 [details]
Bug 1373823 - Fix about:telemetry data preferences change button in beta55

fix link to preferences in about:telemetry, beta55+
Attachment #8880007 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
status-firefox55: --- → affected

Comment 10

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/ed35720fd07c
status-firefox55: affected → fixed
QA Whiteboard: [good first verify]
Successfully Reproduced the bug in Nightly 56.0a1 (2017-06-16) on windows 10 x64

Verified as fixed with latest Firefox Beta 56.0b2 (Build ID: 20170810180547) 

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: [good first verify] → [good first verify] [bugday-20170809]
You need to log in before you can comment on or make changes to this bug.