Closed Bug 1374023 Opened 7 years ago Closed 7 years ago

Site Data section appears when just clicking search field

Categories

(Firefox :: Settings UI, defect, P1)

56 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 56
Tracking Status
firefox56 --- verified

People

(Reporter: euthanasia_waltz, Assigned: rickychien)

References

Details

(Whiteboard: [photon-preference])

Attachments

(1 file)

STR:
1. Open Options(Preferences)
2. Click search field

AR:
Site Data section appears
 at the bottom of the page in General,
 at the top of the page in Files & Applications, Firefox Account, Updates.

ER:
Nothing happens because of just a click.

This occurs once per opening Options(Preferences). Not on every tabs(General..Updates) in the same tab(browsing tab).
Blocks: 1353954
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: [photon-preference][triage]
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Flags: qe-verify+
Priority: -- → P1
Has STR: --- → yes
QA Contact: hani.yacoub
Whiteboard: [photon-preference][triage] → [photon-preference]
Target Milestone: --- → Firefox 56
Jaws, can you take a look and help review the patch? thanks
Flags: needinfo?(jaws)
Comment on attachment 8879038 [details]
Bug 1374023 - Avoid showing Site Data when clicking search field

https://reviewboard.mozilla.org/r/150356/#review155716

This looks right. Switching categories already handles setting hidden to true/false, and if the current category isn't Privacy, then clicking on the search field would initialize the Privacy category and in turn was displaying these groups when they shouldn't have been displayed.
Attachment #8879038 - Flags: review?(jaws) → review+
Flags: needinfo?(jaws)
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d117f7391add
Avoid showing Site Data when clicking search field r=jaws
https://hg.mozilla.org/mozilla-central/rev/d117f7391add
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Build ID: 20170629030206
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

Verified as fixed on Firefox Nightly 56.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: