1374023 - Site Data section appears when just clicking search field

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[atlanto]

STR:
1. Open Options(Preferences)
2. Click search field

AR:
Site Data section appears
 at the bottom of the page in General,
 at the top of the page in Files & Applications, Firefox Account, Updates.

ER:
Nothing happens because of just a click.

This occurs once per opening Options(Preferences). Not on every tabs(General..Updates) in the same tab(browsing tab).

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1374023 - Avoid showing Site Data when clicking search field

Review commit: https://reviewboard.mozilla.org/r/150356/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150356/

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Jaws, can you take a look and help review the patch? thanks

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8879038 [details]
Bug 1374023 - Avoid showing Site Data when clicking search field

https://reviewboard.mozilla.org/r/150356/#review155716

This looks right. Switching categories already handles setting hidden to true/false, and if the current category isn't Privacy, then clicking on the search field would initialize the Privacy category and in turn was displaying these groups when they shouldn't have been displayed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d117f7391add
Avoid showing Site Data when clicking search field r=jaws

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d117f7391add

Comment 6

[Hani Yacoub, Desktop QA]

Build ID: 20170629030206
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

Verified as fixed on Firefox Nightly 56.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.