1353954 - Enable the browser.preferences.search preference to turn on in-content filtering of the preferences

Status: VERIFIED FIXED

(Firefox :: Settings UI, enhancement, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

The pref controls whether the search field within the about:preferences is visible.

We may enable it for Nightly builds only at some point, but will eventually need to enable it for release builds. This bug will track enabling it for release builds.

Comment 1

[Evan Tseng [:evanxd]]

Neeinfo myself, I will work on this once we could enable the search feature.

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1353954 - Enable browser.preferences.search by default

Review commit: https://reviewboard.mozilla.org/r/148814/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148814/

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8877421 [details]
Bug 1353954 - Enable browser.preferences.search by default

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148814/diff/1-2/

Comment 4

[Ricky Chien [:rickychien] (inactive)]

There are few bugs remained for completing Photon Search, we've decided to enable this flag earlier and hopefully we can start putting QA work once it get finished.

Once this feature is stable, we'll have a follow-up to clean up all Enable browser.preferences.search flags (firefox.js and mochites) in codebase.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Release Note Request (optional, but appreciated)
[Why is this notable]: Enables searching within preferences
[Affects Firefox for Android]: no
[Suggested wording]: Search within the Preferences to find relevant options across categories
[Links (documentation, blog post, etc)]: n/a

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8877421 [details]
Bug 1353954 - Enable browser.preferences.search by default

https://reviewboard.mozilla.org/r/148814/#review153536

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abf6d08bb386
Enable browser.preferences.search by default r=jaws

Comment 8

[Pascal Chevrel:pascalc]

release note added for Firefox Nigtly 56.0a1. I changed slightly the wording for "Search within the Options/Preferences panel to find relevant options across categories"

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/abf6d08bb386

Comment 10

[Rezwana islam ria]

This feature "Enable the browser.preferences.search preference to turn on in-content filtering of the preferences" has been implemented with Latest Nightly 56.0a1 on Windows 10 (64 Bit). 

Build ID: 20170615030208
User Agent : Mozilla/5.0 (Windows NT 10.0; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0

[bugday-20170614]

Comment 11

[Hani Yacoub, Desktop QA]

Build ID: 20170618030207
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

"browser.preferences.search" pref is turned on by default on Firefox Nightly 56.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.

Comment 12

[Gerry Chang [:gchang]]

Added to Fx56 (Beta) release notes.