Enable the browser.preferences.search preference to turn on in-content filtering of the preferences

VERIFIED FIXED in Firefox 56

Status

()

Firefox
Preferences
P1
normal
VERIFIED FIXED
4 months ago
21 days ago

People

(Reporter: jaws, Assigned: rickychien)

Tracking

(Blocks: 1 bug)

55 Branch
Firefox 56
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(relnote-firefox 56+, firefox56 verified)

Details

(Whiteboard: [photon-preference] )

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

The pref controls whether the search field within the about:preferences is visible.

We may enable it for Nightly builds only at some point, but will eventually need to enable it for release builds. This bug will track enabling it for release builds.

Updated

4 months ago
Blocks: 1356269

Updated

4 months ago
Blocks: 1357285
No longer blocks: 1356269

Updated

4 months ago
Whiteboard: [photon-preference]

Updated

4 months ago
Target Milestone: --- → Firefox 56

Updated

4 months ago
QA Contact: hani.yacoub

Updated

4 months ago
Flags: qe-verify+

Updated

4 months ago
Priority: -- → P2

Comment 1

3 months ago
Neeinfo myself, I will work on this once we could enable the search feature.
Flags: needinfo?(evan)
(Assignee)

Updated

2 months ago
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Priority: P2 → P1
(Assignee)

Updated

2 months ago
Flags: needinfo?(evan)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 4

2 months ago
There are few bugs remained for completing Photon Search, we've decided to enable this flag earlier and hopefully we can start putting QA work once it get finished.

Once this feature is stable, we'll have a follow-up to clean up all Enable browser.preferences.search flags (firefox.js and mochites) in codebase.
Release Note Request (optional, but appreciated)
[Why is this notable]: Enables searching within preferences
[Affects Firefox for Android]: no
[Suggested wording]: Search within the Preferences to find relevant options across categories
[Links (documentation, blog post, etc)]: n/a
relnote-firefox: --- → ?
(Reporter)

Updated

2 months ago
status-firefox55: affected → ---
status-firefox56: --- → affected
(Reporter)

Comment 6

2 months ago
mozreview-review
Comment on attachment 8877421 [details]
Bug 1353954 - Enable browser.preferences.search by default

https://reviewboard.mozilla.org/r/148814/#review153536
Attachment #8877421 - Flags: review?(jaws) → review+

Comment 7

2 months ago
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/abf6d08bb386
Enable browser.preferences.search by default r=jaws
release note added for Firefox Nigtly 56.0a1. I changed slightly the wording for "Search within the Options/Preferences panel to find relevant options across categories"
https://hg.mozilla.org/mozilla-central/rev/abf6d08bb386
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox56: affected → fixed
Resolution: --- → FIXED

Updated

2 months ago
Depends on: 1373535

Comment 10

2 months ago
This feature "Enable the browser.preferences.search preference to turn on in-content filtering of the preferences" has been implemented with Latest Nightly 56.0a1 on Windows 10 (64 Bit). 

Build ID: 20170615030208
User Agent : Mozilla/5.0 (Windows NT 10.0; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0

[bugday-20170614]

Updated

2 months ago
Depends on: 1374023

Comment 11

2 months ago
Build ID: 20170618030207
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

"browser.preferences.search" pref is turned on by default on Firefox Nightly 56.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
status-firefox56: fixed → verified
(Assignee)

Updated

2 months ago
No longer depends on: 1373535
Added to Fx56 (Beta) release notes.
relnote-firefox: ? → 56+
You need to log in before you can comment on or make changes to this bug.