Closed
Bug 1374093
Opened 7 years ago
Closed 7 years ago
Port bug 1369025 to C-C {Remove mozilla::dom::EncodingUtils}, port bug 1372886 to C-C [Remove two last parameters of nsIConverterOutputStream::Init]
Categories
(MailNews Core :: Internationalization, defect)
MailNews Core
Internationalization
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 56.0
People
(Reporter: Paenglab, Assigned: jorgk-bmo)
Details
Attachments
(2 files, 3 obsolete files)
|
11.87 KB,
patch
|
Details | Diff | Splinter Review | |
|
2.07 KB,
patch
|
Details | Diff | Splinter Review |
TB build fails with: 1:07.01 z:/Mozilla/comm-central/mailnews/intl/nsCharsetAlias.cpp(7): fatal error C1083: Cannot open include file: 'mozilla/dom/EncodingUtils.h': No such file or directory 1:07.03 z:/Mozilla/comm-central/mozilla/config/rules.mk:1010: recipe for target 'Unified_cpp_mailnews_intl0.obj' failed 1:07.04 mozmake.EXE[4]: *** [Unified_cpp_mailnews_intl0.obj] Error 2 Fallout from bug 1369025 I think.
|
Reporter | |
Comment 1•7 years ago
|
||
Hmm, it seems bug 1372886 needs to be ported too.
|
Assignee | |
Comment 2•7 years ago
|
||
This should fix the EncodingUtils part.
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•7 years ago
|
||
This compiles now. As for bug 1372886: This will only fail in C++ code, so nsBeckyUtils.cpp. Anyway, patch coming here, too.
Attachment #8878922 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•7 years ago
|
||
C++ callers only to make it compile again.
|
|
Assignee | |
Comment 5•7 years ago
|
||
Bug 1372886 talks about nsIConverterInputStream, but in fact they removed the parameter from nsIConverterOutputStream.
Summary: Port bug 1369025 to C-C {Remove mozilla::dom::EncodingUtils} → Port bug 1369025 to C-C {Remove mozilla::dom::EncodingUtils}, port bug 1372886 to C-C [Remove two last parameters of nsIConverterOutputStream::Init]
|
|
Assignee | |
Comment 6•7 years ago
|
||
Full patch, C++ and JS callers.
Attachment #8878924 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•7 years ago
|
||
Attachment #8878923 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 8•7 years ago
|
||
https://hg.mozilla.org/comm-central/rev/978085bf1e8265c57b70b9ebcefcba19f082c6b8 https://hg.mozilla.org/comm-central/rev/484beb60833c61561f1c447b972e7d4f55e52633 Thanks for reporting this, Richard!
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 56.0
You need to log in
before you can comment on or make changes to this bug.
Description
•