Closed Bug 1374094 Opened 3 years ago Closed 1 year ago

Update SeaMonkey debugQA extension

Categories

(SeaMonkey :: General, enhancement)

enhancement
Not set

Tracking

(seamonkey2.49esr wontfix, seamonkey2.53? affected, seamonkey2.57esr+ fixed, seamonkey2.63 wontfix)

RESOLVED FIXED
seamonkey 2.70
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.53 ? affected
seamonkey2.57esr + fixed
seamonkey2.63 --- wontfix

People

(Reporter: frg, Assigned: frg)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

debugQA should be compatible with SeaMonkey 2.49.1 when a new release is put on AMO. The current debugQA is only comaptible with SeaMonkey 2.50 and up because of Bug 1322414 (remove content-primary). Bug 1324899 fixed the backwards comaptibility for DOMi so the same workaround can be applied here. Also moztrap has been discontinued and needs to be removed from the menu. 

For the editor tests to work Bug 1364772 needs to be fixed too.
Attached patch 1374094-debugQA245.patch (obsolete) — Splinter Review
Tested with Bug 1364772 fixed 2.53a1 and 2.49.1.
Attachment #8878921 - Flags: review?(iann_bugzilla)
Comment on attachment 8878921 [details] [diff] [review]
1374094-debugQA245.patch

>+  // Fix up content primary for older versions.
>+  // See bug 1324899.
>+  if (Services.vc.compare(Services.appinfo.platformVersion, "53.0a1") < 0) {
>+    document.getElementById("content-frame").setAttribute("type",
>+                                                          "content-primary");
>+  }
As TextEditorOnLoad() is only used by debugQA then the whole of this could be moved to the top of that function, thus saving adding another file and simplifying the patch. You may find Services.jsm already loaded in the context.

f+ for the moment
Attachment #8878921 - Flags: review?(iann_bugzilla) → feedback+
> As TextEditorOnLoad() is only used by debugQA

Do you mean moving TextEditorOnLoad() into debugQA? This might break other add-ons which use this function? 

The setAttribute needs to stay in debugQA obviously. It could probably be moved into debugQAEditorOverlay.js but this would all muddle it a bit.
Flags: needinfo?(iann_bugzilla)
(In reply to Frank-Rainer Grahl (:frg) from comment #3)
> > As TextEditorOnLoad() is only used by debugQA
> 
> Do you mean moving TextEditorOnLoad() into debugQA? This might break other
> add-ons which use this function? 
No, I mean don't create a new file, just add the new code to TextEditorOnLoad()
Flags: needinfo?(iann_bugzilla)
> No, I mean don't create a new file, just add the new code to TextEditorOnLoad()

Can't be done. editingOverlay.js is part of SeaMonkey. The code needs to be in the add-on and must be called during load to set the attribute only when debugQA is used with SeaMonkey 2.49.x and older versions. Only needed so that a new AMO version works with them. Check bug 1324899 for DOMi.
Comment on attachment 8878921 [details] [diff] [review]
1374094-debugQA245.patch

(In reply to Frank-Rainer Grahl (:frg) from comment #5)
> > No, I mean don't create a new file, just add the new code to TextEditorOnLoad()
> 
> Can't be done. editingOverlay.js is part of SeaMonkey. The code needs to be
> in the add-on and must be called during load to set the attribute only when
> debugQA is used with SeaMonkey 2.49.x and older versions. Only needed so
> that a new AMO version works with them. Check bug 1324899 for DOMi.

How do we tell if any Add-ons are using TextEditorOnLoad()?
If none, merge into new function in debugQATextEditorShell.js

>+++ b/suite/debugQA/content/debugQATextEditorShell.js
>@@ -0,0 +1,17 @@
>+/* -*- Mode: Java; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- *
>+/* This Source Code Form is subject to the terms of the Mozilla Public
>+ * License, v. 2.0. If a copy of the MPL was not distributed with this
>+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>+
>+Components.utils.import("resource://gre/modules/Services.jsm");
>+
>+function debugQATextEditorShell_load()
Maybe debugQATextEditorOnLoad() instead

>+{
>+  // Fix up content primary for older versions.
>+  // See bug 1324899.
>+  if (Services.vc.compare(Services.appinfo.platformVersion, "53.0a1") < 0) {
>+    document.getElementById("content-frame").setAttribute("type",
>+                                                          "content-primary");
>+  }
>+  TextEditorOnLoad();
>+}

r=me either way.
Attachment #8878921 - Flags: feedback+ → review+
Jorg,

would you be ok with removing TextEditorOnLoad() from editor/ui/composer/content/editingOverlay.js?

Seems to be only needed in the SeaMonkey debugQA addon. Still need to check if there will be any fallout in the addon but doesn't think so. Everone else seems to use EditorOnLoad().

Do you think other addons use it? Dind't find any references searching for it.
Flags: needinfo?(jorgk)
No problem.
Flags: needinfo?(jorgk)
Summary: Update debugQA extension for older SeaMonkey versions → Update SeaMonkey debugQA extension

The old patch has overstayed its welcome. debugQA is now integrated into SeaMonkey and no longer tied to the Nightlies. At this point in time we no longer care about aynthing below 2.53.
New patch is compatible with 2.53 and up. Trunk would need other additonal patches. We deal with this or not later.

Basically clean up now. Some outdated web sites removed and some added. Editor change removed and new routine no longer neccesary. If we ever come to Nightly we can clean it up here.

Attachment #8878921 - Attachment is obsolete: true
Attachment #9073860 - Flags: review?(iann_bugzilla)
Attachment #9073860 - Flags: approval-comm-release?
Attachment #9073860 - Flags: approval-comm-esr60?
Comment on attachment 9073860 [details] [diff] [review]
1374094-debugQA.patch

[Triage Comment]
What's the reason behind removing www.mozilla.org and quality.mozilla.org

r/a=me with that answered
Flags: needinfo?(frgrahl)
Attachment #9073860 - Flags: review?(iann_bugzilla)
Attachment #9073860 - Flags: review+
Attachment #9073860 - Flags: approval-comm-release?
Attachment #9073860 - Flags: approval-comm-release+
Attachment #9073860 - Flags: approval-comm-esr60?
Attachment #9073860 - Flags: approval-comm-esr60+

What's the reason behind removing www.mozilla.org and quality.mozilla.org

Discussed on irc a while ago. A follow-up bug should be filed for a new developer menu. On quality.mozilla.org there is also nothing left of value for SeaMonkey devs or users.

Flags: needinfo?(frgrahl)
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Blocks: 1569431
You need to log in before you can comment on or make changes to this bug.