1374110 - Remove magnifyWithEvent and related code

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, enhancement, P3)

Description

[Jonathan Watt [:jwatt]]

This seems to be Lion code according to the in-source comments.

Passes Try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=af1c0eb7288417f856e8929d9da8a28957f7d298

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Markus Stange [:mstange]]

According to bug 1052253 comment 68, this code is still needed until we start building with a 10.11+ SDK.

Comment 3

[Jonathan Watt [:jwatt]]

Comment on attachment 8878931 [details] [diff] [review]
patch

The comment in the code is misleading. We currently still need this code for pinch zooming until we update the SDK.

Comment 4

[Jonathan Watt [:jwatt]]

Oh, you already added a comment, Markus. I missed that.

Comment 5

[Markus Stange [:mstange]]

This can probably land now, because the SDK update in bug 1324892 has happened. But I think it would be better to wait for the 58 cycle to start, because we might still want to back out the SDK update in 57.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/791d50892077
Remove magnifyWithEvent and related code. r=mstange

Comment 7

[Stephen A Pohl [:spohl] (OOO until 2/27)]

[Tracking Requested - why for this release]:
This is needed to uplift bug 1399086, which is tracking 57.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/791d50892077

Comment 9

[Stephen A Pohl [:spohl] (OOO until 2/27)]

(In reply to Stephen A Pohl [:spohl] from comment #7)
> [Tracking Requested - why for this release]:
> This is needed to uplift bug 1399086, which is tracking 57.

Actually, we can just uplift attachment 8912344 [details] [diff] [review] from bug 1399086, so we don't need to uplift this here.

Comment 10

[Patrick Walton (:pcwalton)]

This seems to have broken pinch zoom for Web apps on the Mac. For the Pathfinder 2 demo I was relying on checking `mouseWheel` with the control key pressed, as documented on MDN here:

https://developer.mozilla.org/en-US/docs/Web/API/WheelEvent#Browser_compatibility

Is there a preferred alternative that enables Web apps to support pinch zoom?

Comment 11

[Markus Stange [:mstange]]

This was not supposed to break anything.

Comment 12

[Patrick Walton (:pcwalton)]

Steps to reproduce the bug: Pinch zoom on my MacBook Pro trackpad would zoom the page prior to this change (just as holding Ctrl and using two-finger swipe does), and it doesn't zoom the page anymore.

Alternately: Add an event listener to mousewheel to some element on the page. Observe that events no longer fire when the user pinch zooms.

If this is in fact a bug, would you prefer I reopen this bug or create a new one?