1404664 - Restore pinch zoom gesture support on macOS

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P1)

Description

[Stephen A Pohl [:spohl] (OOO until 2/27)]

Misunderstood in-code comments resulted in the accidental removal of pinch zoom gesture support on macOS in bug 1374110. The in-code comments were meant to explain that "smart zoom gestures", i.e. two-finger double taps on track pads were implemented in magnifyWithEvent: on macOS 10.7 and in smartMagnifyWithEvent: on macOS 10.8 and above. However, magnifyWithEvent: continues to be necessary to support pinch zoom gestures on any version of macOS and shouldn't have been removed.

Comment 1

[Stephen A Pohl [:spohl] (OOO until 2/27)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7574ec43cf9f861a5342f6718ff7b8d7a86e4c26

Comment 2

[Stephen A Pohl [:spohl] (OOO until 2/27)]

Attachment: Patch

This patch restores functionality and accounts for the changes in bug 1399086 as well.

Comment 3

[Stephen A Pohl [:spohl] (OOO until 2/27)]

Patrick, could you give this try build a shot and verify that pinch zoom gestures work again for you? Thanks!

https://queue.taskcluster.net/v1/task/dSwLp_yRQv6dwXh5zDA7Vg/runs/0/artifacts/public/build/target.dmg

Comment 4

[Stephen A Pohl [:spohl] (OOO until 2/27)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/78d84bc21e7cbbeebc9cc2ef3723917f08234bfa
Bug 1404664: Restore pinch zoom gesture support on macOS. r=mstange

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/78d84bc21e7c

Comment 6

[Patrick Walton (:pcwalton)]

Yup, works fine for me.