Closed Bug 1404664 Opened 7 years ago Closed 7 years ago

Restore pinch zoom gesture support on macOS

Categories

(Core :: Widget: Cocoa, defect, P1)

All
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: spohl, Assigned: spohl)

References

Details

Attachments

(1 file)

Misunderstood in-code comments resulted in the accidental removal of pinch zoom gesture support on macOS in bug 1374110. The in-code comments were meant to explain that "smart zoom gestures", i.e. two-finger double taps on track pads were implemented in magnifyWithEvent: on macOS 10.7 and in smartMagnifyWithEvent: on macOS 10.8 and above. However, magnifyWithEvent: continues to be necessary to support pinch zoom gestures on any version of macOS and shouldn't have been removed.
Attached patch PatchSplinter Review
This patch restores functionality and accounts for the changes in bug 1399086 as well.
Attachment #8914021 - Flags: review?(mstange)
Patrick, could you give this try build a shot and verify that pinch zoom gestures work again for you? Thanks!

https://queue.taskcluster.net/v1/task/dSwLp_yRQv6dwXh5zDA7Vg/runs/0/artifacts/public/build/target.dmg
Flags: needinfo?(pwalton)
Attachment #8914021 - Flags: review?(mstange) → review+
https://hg.mozilla.org/mozilla-central/rev/78d84bc21e7c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Yup, works fine for me.
Flags: needinfo?(pwalton)
You need to log in before you can comment on or make changes to this bug.