1374399 - Enable WebVR by default on macOS

Status: RESOLVED FIXED

(Core :: WebVR, enhancement, P2)

Comment 1

[:kip (Kearwood Gilbert)]

Now that Bug 1383907 has enabled tests and macOS High Sierra is coming out of Beta, expect that this can be enabled by default in FF58.  After the FF57 uplift date, I will send out an "Intent to Ship" email and flip the pref on if there are no objections.

Comment 2

[:kip (Kearwood Gilbert)]

Attachment: Bug 1374399 - Enable WebVR by default for macOS

Review commit: https://reviewboard.mozilla.org/r/181970/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181970/

Comment 3

[:kip (Kearwood Gilbert)]

An intent-to-ship has been sent: https://groups.google.com/forum/#!topic/mozilla.dev.platform/MCSJOhbqSVE

As soon as we have r+ on the patch, we are ready to land.

Comment 4

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8910532 [details]
Bug 1374399 - Enable WebVR by default for macOS

https://reviewboard.mozilla.org/r/181970/#review190878

LGTM. But, we should open a follow-up bug for mac to enable mochitest and reftest on release channel.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03fee7b5807d
Enable WebVR by default for macOS r=daoshengmu

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/03fee7b5807d

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Release Note Request (optional, but appreciated)
[Why is this notable]: New cool feature
[Affects Firefox for Android]: No
[Suggested wording]: WebVR has been enabled for Mac OS X users
[Links (documentation, blog post, etc)]:

Comment 8

[Chris Mills [:cmills]]

I've documented this by adding a note to the Fx58 rel notes:

https://developer.mozilla.org/en-US/Firefox/Releases/58#DOM

And updating the WebVR support info on our browser compat data repo:

https://github.com/mdn/browser-compat-data/pull/564

Comment 9

[Gerry Chang [:gchang]]

Added in Beta58 release notes.

Comment 10

[:kip (Kearwood Gilbert)]

(In reply to Gerry Chang [:gchang] from comment #9)
> Added in Beta58 release notes.

Please note my comment I have added to the release notes doc, copied here for reference:

WebVR is working on macOS with SteamVR and the HTC Vive; however, SoftVision has had technical difficulties with their test hardware (due to Apple bug, not in their control) and has not been able to verify for QA. I have been advised to enable WebVR on macOS only for Nightly and DevEdition until SoftVision is able to complete QA. I am prioritizing a patch to update the prefs accordingly in Bug 1426500.

Comment 11

[Gerry Chang [:gchang]]

Hi :kip,
I've removed this one. Thanks.