1374440 - max-message-size should only be emitted with EOR support

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: Bug 1374440: stop sending max-message-size.

Review commit: https://reviewboard.mozilla.org/r/150586/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150586/

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8879310 [details]
Bug 1374440: stop sending max-message-size.

https://reviewboard.mozilla.org/r/150586/#review155334

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a60b36252622
stop sending max-message-size. r=jesup

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a60b36252622

Comment 5

[Nils Ohlmeier [:drno]]

Comment on attachment 8879310 [details]
Bug 1374440: stop sending max-message-size.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1335262
[User impact if declined]: The signaling emitted through bug 1335262 needs to be emitted only when bug 979417 lands to allow us detecting that the feature in bug 979417 is available. So without this patch WebRTC data channels might not work between different Firefox versions any more.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: It only turns off emitting a single thing in WebRTC's signaling, which Firefox did not used to emit before landing bug 1335262.
[String changes made/needed]: N/A

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 8879310 [details]
Bug 1374440: stop sending max-message-size.

webrtc fix for beta55

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a48ce5c2f87a

Comment 8

[Cornel Ionce [:noni] [Hubs QA]]

Based on comment 5, this does not manual coverage. 
Updating the qe‑verify flag to reflect this.