1374563 - Enable highlighting screenshot widget by UITour

Status: RESOLVED DUPLICATE of bug 1371543

(Firefox :: Tours, enhancement, P2)

Description

[KM Lee [:rexboy] (inactivate after Sep. 22)]

We need to enabled Mozilla.UITour.showHighlight("screenshot") to highlight the screenshot widget on navbar, if exist.

Comment 1

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: Bug 1374563 - Enable highlighting screenshot widget by UITour.

Review commit: https://reviewboard.mozilla.org/r/150764/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150764/

Comment 2

[:Gijs (he/him)]

We're going to remove the button as part of Photon and have an entry in the page action menu instead. So as it is, this feels like it will soon be dead code and then we'll need to reimplement this. Is it actually necessary to implement this in this way right now?

Comment 3

[:Gijs (he/him)]

Comment on attachment 8879456 [details]
Bug 1374563 - Enable highlighting screenshot widget by UITour.

https://reviewboard.mozilla.org/r/150764/#review155556

Clearing given ni in the bug.

::: browser/components/uitour/test/browser_UITour_availableTargets.js:110
(Diff revision 1)
>    CustomizableUI.reset();
> +  // Resetting UI gets rid of screenshot which is not in the default set. It
> +  // needs to be added back manually.
> +  if (hasScreenshot) {
> +    CustomizableUI.addWidgetToArea("screenshots_mozilla_org-browser-action", CustomizableUI.AREA_NAVBAR);
> +  }
> +

There are no assertions here that would require adding it back, and now this test doesn't leave the browser in the default state.

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Thanks for the timely reply and information.
Given the current plan in bug 1366041, I’ll just wait for the page action menu to be landed and revise the patch. 
And we can move following reviews to bug 1371543.

Comment 6

[Francis Lee [:frlee]]

remove whiteboard tag due to its DUPLICATE