Enable highlighting screenshot widget by UITour

RESOLVED DUPLICATE of bug 1371543

Status

()

Firefox
Tours
P2
normal
RESOLVED DUPLICATE of bug 1371543
6 months ago
5 months ago

People

(Reporter: rexboy, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

We need to enabled Mozilla.UITour.showHighlight("screenshot") to highlight the screenshot widget on navbar, if exist.
Summary: Enable highlighting screenshot with dropdown displayed with UITour → Enable highlighting screenshot widget by UITour
Comment hidden (mozreview-request)

Comment 2

6 months ago
We're going to remove the button as part of Photon and have an entry in the page action menu instead. So as it is, this feels like it will soon be dead code and then we'll need to reimplement this. Is it actually necessary to implement this in this way right now?
Flags: needinfo?(rexboy)

Comment 3

6 months ago
mozreview-review
Comment on attachment 8879456 [details]
Bug 1374563 - Enable highlighting screenshot widget by UITour.

https://reviewboard.mozilla.org/r/150764/#review155556

Clearing given ni in the bug.

::: browser/components/uitour/test/browser_UITour_availableTargets.js:110
(Diff revision 1)
>    CustomizableUI.reset();
> +  // Resetting UI gets rid of screenshot which is not in the default set. It
> +  // needs to be added back manually.
> +  if (hasScreenshot) {
> +    CustomizableUI.addWidgetToArea("screenshots_mozilla_org-browser-action", CustomizableUI.AREA_NAVBAR);
> +  }
> +

There are no assertions here that would require adding it back, and now this test doesn't leave the browser in the default state.
Attachment #8879456 - Flags: review?(gijskruitbosch+bugs)

Updated

6 months ago
See Also: → bug 1371543
Thanks for the timely reply and information.
Given the current plan in bug 1366041, I’ll just wait for the page action menu to be landed and revise the patch. 
And we can move following reviews to bug 1371543.
Flags: needinfo?(rexboy)
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1371543

Comment 6

6 months ago
remove whiteboard tag due to its DUPLICATE
Whiteboard: [photon-onboarding]
No longer blocks: 1371535
You need to log in before you can comment on or make changes to this bug.