1374584 - ”Find a replacement” button is not readable on hover

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Vasilica Tamas, QA [:vtamas]]

Attachment: Animation.gif

[Affected versions]:
Firefox 56.0a1 (2017-06-19)
Firefox 55.0b2 (20170615063713)
 
[Affected platforms]:
Windows 10 64-bit
Ubuntu 16.04 32-bit
 
[Steps to reproduce]:
1.Launch Firefox with a clean profile.
2.Install a legacy add-on.
3.Navigate to about:config and toggle the value of extensions.legacy.enabled to false.
4.Go to about:addons -> Legacy Extensions tab.
5.Hover over "Find a Replacement" button.
 
 
[Expected Results]:
“Find a Replacement” button has a readable font.
 
 
[Actual Results]:
- The background button becomes gray on hover and the text maintains its white font color.
- See attached screencast.

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1374584 Add hover styling for find replacement button

Review commit: https://reviewboard.mozilla.org/r/151972/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151972/

Comment 2

[Andrew Swan [:aswan]]

Emanuela, can you review the styles in the attached patch?

Comment 3

[Mark Striemer [:mstriemer]]

Comment on attachment 8880641 [details]
Bug 1374584 Add hover styling for find replacement button

https://reviewboard.mozilla.org/r/151972/#review158560

Unrelated to this change but the non-hover state has a grey border still. It would be good to make that consistent with the hover state.

Comment 4

[Andrew Swan [:aswan]]

Comment on attachment 8880641 [details]
Bug 1374584 Add hover styling for find replacement button

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151972/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a67b0b5fc71
Add hover styling for find replacement button r=mstriemer

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3a67b0b5fc71

Comment 7

[Julien Cristau [:jcristau]]

extensions.legacy.enabled is true in 55

Comment 8

[Vasilica Tamas, QA [:vtamas]]

Attachment: Animation.gif

Verified as fixed on Firefox 56.0a1 (2017-07-10) under Windows 10 64-bit, Ubuntu 16.04 32-bit and Mac OS X 10.12.1. “Find a Replacement” button has a blue readable font on hover.
(But, the same unreadable style is displayed on click - issue tracked by Bug 1379952)