”Find a replacement” button is not readable on hover

VERIFIED FIXED in Firefox 56

Status

()

defect
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: vasilica.mihasca, Assigned: aswan)

Tracking

Trunk
mozilla56
Points:
---

Firefox Tracking Flags

(firefox54 unaffected, firefox55 disabled, firefox56 verified)

Details

Attachments

(3 attachments)

Posted image Animation.gif
[Affected versions]:
Firefox 56.0a1 (2017-06-19)
Firefox 55.0b2 (20170615063713)
 
[Affected platforms]:
Windows 10 64-bit
Ubuntu 16.04 32-bit
 
[Steps to reproduce]:
1.Launch Firefox with a clean profile.
2.Install a legacy add-on.
3.Navigate to about:config and toggle the value of extensions.legacy.enabled to false.
4.Go to about:addons -> Legacy Extensions tab.
5.Hover over "Find a Replacement" button.
 
 
[Expected Results]:
“Find a Replacement” button has a readable font.
 
 
[Actual Results]:
- The background button becomes gray on hover and the text maintains its white font color.
- See attached screencast.
Comment hidden (mozreview-request)
(Assignee)

Comment 2

2 years ago
Emanuela, can you review the styles in the attached patch?
Assignee: nobody → aswan
Flags: needinfo?(emanuela)
(Assignee)

Updated

2 years ago
Attachment #8880641 - Flags: review?(mstriemer)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8880641 [details]
Bug 1374584 Add hover styling for find replacement button

https://reviewboard.mozilla.org/r/151972/#review158560

Unrelated to this change but the non-hover state has a grey border still. It would be good to make that consistent with the hover state.
Attachment #8880641 - Flags: review?(mstriemer) → review+
Comment hidden (mozreview-request)

Comment 5

2 years ago
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3a67b0b5fc71
Add hover styling for find replacement button r=mstriemer

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3a67b0b5fc71
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
extensions.legacy.enabled is true in 55
Posted image Animation.gif
Verified as fixed on Firefox 56.0a1 (2017-07-10) under Windows 10 64-bit, Ubuntu 16.04 32-bit and Mac OS X 10.12.1. “Find a Replacement” button has a blue readable font on hover.
(But, the same unreadable style is displayed on click - issue tracked by Bug 1379952)
(Assignee)

Updated

2 years ago
Flags: needinfo?(emanuela)
You need to log in before you can comment on or make changes to this bug.