Closed Bug 1374588 Opened 5 years ago Closed 5 years ago

Labels aren't highlighted after performing a search


(Firefox :: Preferences, defect, P1)

56 Branch



Firefox 56
Tracking Status
firefox56 --- verified


(Reporter: hani.yacoub, Assigned: rickychien)


(Blocks 1 open bug)


(Whiteboard: [photon-preference])


(2 files)

Attached image Label.png
[Affected versions]: 
Nightly 56.0a1

[Affected platforms]:
Platforms: Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.

[Steps to reproduce]:
1. Launch Firefox, go to about:config and search for "" and set it value to true.
2. Go to "about:preferences".
3. Search for "Nightly" in the search field.

[Expected result]:
Nightly in "When Nightly starts" should be highlighted.

[Actual result]:
Nightly in "When Nightly starts" is not highlighted.

All labels can't be highlighted after performing a search in "about:preferences" page.
Blocks: 1357285
Whiteboard: [photon-preference]

I cannot reproduce this issue on my latest Nightly. Can you try latest Nightly build and verify again?

I suspect this issue has been fixed recently.

thank you
Flags: needinfo?(hani.yacoub)
It's reproducible on this build Firefox Nightly 56.0a1(2017-06-19)(64-bit), I'll wait for the next build and I'll let you know.
Flags: needinfo?(hani.yacoub)
It's also reproducible with Firefox Nightly 56.0a1 (2017-06-20)(64-bit) but only on Windows and Ubuntu. 
It's not reproducible on Mac OS X 10.12.
Flags: needinfo?(rchien)
Hmm...sounds interesting since it breaks on Windows and Linux.

Thanks for reporting this issue. We'll take a look.
Has STR: --- → yes
Flags: needinfo?(rchien) → qe-verify+
Whiteboard: [photon-preference] → [photon-preference][triage]
Priority: -- → P2
Whiteboard: [photon-preference][triage] → [photon-preference]
Assignee: nobody → rchien
Priority: P2 → P1
QA Contact: hani.yacoub
Probably worthy to look at code touched by bug 1360500.
(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #5)
> Probably worthy to look at code touched by bug 1360500.

Specifically, the color set by

when the function is called.
Note that this issue is also reproducible on macOS by setting `ui.key.menuAccessKey = 17` (Windows sets to 18, please see [1].)

After enabling menuAccessKey, all label and description elements will be added an additional span wrapping around the Accesskey text node. As a result, the search algorithm is unable to detect and highlight the proper text as expected.

Patch has been verified on macOS with setting `ui.key.menuAccessKey = 17` and Windows.
Comment on attachment 8880711 [details]
Bug 1374588 - Labels aren't highlighted after performing a search

Attachment #8880711 - Flags: review?(mconley) → review+
Pushed by
Labels aren't highlighted after performing a search r=mconley
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Build ID: 20170627030209
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

Verified as fixed on Firefox Nightly 56.0a1 on Windows 10 x 64 and Ubuntu 16.04 x64.
You need to log in before you can comment on or make changes to this bug.