Closed Bug 1374596 Opened 7 years ago Closed 7 years ago

Missing headers

Categories

(Core :: Audio/Video: Playback, enhancement)

Product:
Core
Component:
Audio/Video: Playback
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: jya, Assigned: jya)

Details

Attachments

(7 files)

Bug 1374596: P1. Fix MediaStream* headers.
59 bytes, text/x-review-board-request
padenot
: review+
Details
Bug 1374596: P2. Fix Benchmark required headers.
59 bytes, text/x-review-board-request
padenot
: review+
Details
Bug 1374596: P3. Fix MediaStream* headers.
59 bytes, text/x-review-board-request
padenot
: review+
Details
Bug 1374596: P4. Fix CubebUtils headers.
59 bytes, text/x-review-board-request
padenot
: review+
Details
Bug 1374596: P5. Fix MediaDecoder* headers.
59 bytes, text/x-review-board-request
padenot
: review+
Details
Bug 1374596: P6. More missing headers fixes.
59 bytes, text/x-review-board-request
padenot
: review+
Details
Bug 1374596: P7. Fix includes as per coding style.
59 bytes, text/x-review-board-request
padenot
: review+
Details 
Following bug 1374389

changing the number of files in unified build cause compilation errors.

all due to missing headers.

So let's fix those.
Comment on attachment 8879596 [details]
Bug 1374596: P1. Fix MediaStream* headers.

https://reviewboard.mozilla.org/r/150922/#review156200
Attachment #8879596 - Flags: review?(padenot) → review+
Comment on attachment 8879597 [details]
Bug 1374596: P2. Fix Benchmark required headers.

https://reviewboard.mozilla.org/r/150924/#review156204
Attachment #8879597 - Flags: review?(padenot) → review+
Comment on attachment 8879598 [details]
Bug 1374596: P3. Fix MediaStream* headers.

https://reviewboard.mozilla.org/r/150926/#review156206
Attachment #8879598 - Flags: review?(padenot) → review+
Comment on attachment 8879599 [details]
Bug 1374596: P4. Fix CubebUtils headers.

https://reviewboard.mozilla.org/r/150928/#review156208
Attachment #8879599 - Flags: review?(padenot) → review+
Comment on attachment 8879600 [details]
Bug 1374596: P5. Fix MediaDecoder* headers.

https://reviewboard.mozilla.org/r/150930/#review156210
Attachment #8879600 - Flags: review?(padenot) → review+
Comment on attachment 8879601 [details]
Bug 1374596: P6. More missing headers fixes.

https://reviewboard.mozilla.org/r/150932/#review156212
Attachment #8879601 - Flags: review?(padenot) → review+
Comment on attachment 8879602 [details]
Bug 1374596: P7. Fix includes as per coding style.

https://reviewboard.mozilla.org/r/150934/#review156214
Attachment #8879602 - Flags: review?(padenot) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 4325aa85f8da -d a541b46cb8ff: rebasing 403105:4325aa85f8da "Bug 1374596: P1. Fix MediaStream* headers. r=padenot"
merging dom/media/moz.build
rebasing 403106:d43b03e42d98 "Bug 1374596: P2. Fix Benchmark required headers. r=padenot"
merging dom/media/Benchmark.cpp
rebasing 403107:67ddcfd3fea2 "Bug 1374596: P3. Fix MediaStream* headers. r=padenot"
merging dom/media/CanvasCaptureMediaStream.cpp
merging dom/media/DOMMediaStream.cpp
merging dom/media/MediaStreamTrack.cpp
rebasing 403108:b0ef438b3280 "Bug 1374596: P4. Fix CubebUtils headers. r=padenot"
merging dom/media/CubebUtils.cpp
rebasing 403109:c96c9d228195 "Bug 1374596: P5. Fix MediaDecoder* headers. r=padenot"
merging dom/media/MediaDecoder.cpp
merging dom/media/MediaDecoderReader.cpp
rebasing 403110:9659f6836e63 "Bug 1374596: P6. More missing headers fixes. r=padenot"
rebasing 403111:b3576bf116cc "Bug 1374596: P7. Fix includes as per coding style. r=padenot" (tip)
merging dom/media/Benchmark.cpp
merging dom/media/CanvasCaptureMediaStream.cpp
merging dom/media/CubebUtils.cpp
merging dom/media/DOMMediaStream.cpp
merging dom/media/MediaData.cpp
merging dom/media/MediaData.h
merging dom/media/MediaDecoder.cpp
merging dom/media/MediaDecoderReader.cpp
merging dom/media/MediaFormatReader.cpp
merging dom/media/MediaStreamTrack.cpp
merging dom/media/MediaTimer.cpp
merging dom/media/VideoUtils.cpp
merging dom/media/VideoUtils.h
merging dom/media/platforms/wmf/WMFVideoMFTManager.cpp
warning: conflicts while merging dom/media/MediaData.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 20ce04f18e36 -d 80c24b58dde8: rebasing 403107:20ce04f18e36 "Bug 1374596: P1. Fix MediaStream* headers. r=padenot"
rebasing 403108:0986beae820b "Bug 1374596: P2. Fix Benchmark required headers. r=padenot"
rebasing 403109:5837a404231e "Bug 1374596: P3. Fix MediaStream* headers. r=padenot"
rebasing 403110:e11b73ebfe83 "Bug 1374596: P4. Fix CubebUtils headers. r=padenot"
rebasing 403111:3f56fefce356 "Bug 1374596: P5. Fix MediaDecoder* headers. r=padenot"
rebasing 403112:64f0cfcc4197 "Bug 1374596: P6. More missing headers fixes. r=padenot"
rebasing 403113:bc63aa1a5794 "Bug 1374596: P7. Fix includes as per coding style. r=padenot" (tip)
merging dom/media/MediaData.cpp
merging dom/media/MediaData.h
merging dom/media/MediaFormatReader.cpp
merging dom/media/platforms/wmf/WMFVideoMFTManager.cpp
warning: conflicts while merging dom/media/MediaData.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4bff6ae8d306
P1. Fix MediaStream* headers. r=padenot
https://hg.mozilla.org/integration/autoland/rev/b10bcd01b6fa
P2. Fix Benchmark required headers. r=padenot
https://hg.mozilla.org/integration/autoland/rev/d3bec546dd05
P3. Fix MediaStream* headers. r=padenot
https://hg.mozilla.org/integration/autoland/rev/d9cdcfd490bd
P4. Fix CubebUtils headers. r=padenot
https://hg.mozilla.org/integration/autoland/rev/952493b1f659
P5. Fix MediaDecoder* headers. r=padenot
https://hg.mozilla.org/integration/autoland/rev/f849c637173b
P6. More missing headers fixes. r=padenot
https://hg.mozilla.org/integration/autoland/rev/3ba7f5f7ec36
P7. Fix includes as per coding style. r=padenot
we received an alert for an increase in number of static constructors when this landed:
== Change summary for alert #7449 (as of June 21 2017 12:32 UTC) ==

Regressions:

  1%  compiler_metrics num_static_constructors linux64-stylo debug      203.00 -> 206.00
  1%  compiler_metrics num_static_constructors linux32 debug            203.00 -> 206.00
  1%  compiler_metrics num_static_constructors linux64-noopt debug      215.00 -> 218.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=7449

This is for informational purposes only, there is no policy in place to require a fix for these, but it would be nice to know if this is expected and makes sense.

:froydnj can help answer questions related to that metric.
It makes sense because we unify less files at a time. If unified build didn't yield to a compilation time improvement, we wouldn't have bothered with it :)

This was required because Visual Studio could no longer link the objects found in dom/media as they were too big (bug 1374389)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: