Closed Bug 1374705 Opened 5 years ago Closed 5 years ago

Clean up some unused variables and some unnecessary run_test functions in toolkit/components/places/tests

Categories

(Toolkit :: Places, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

I've cleaned up a few unused vars in toolkit/components/places/tests as I was looking at bug 1094910 and found a few cases where we were getting the bookmarks or history service when we didn't need to. Hence confusing the list on that bug.

I have also cleaned up cases where we're doing:

function run_test() {
  run_next_test();
}

as these are unnecessary as xpcshell's head.js defines it for us already.
Comment on attachment 8879621 [details]
Bug 1374705 - Clean up some unused variables and some unnecessary run_test functions in toolkit/components/places/tests.

https://reviewboard.mozilla.org/r/150966/#review156138

it looks great, thank you. A lot of the tests have really legacy code, but we have too many to convert.
Attachment #8879621 - Flags: review?(mak77) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a7f1ac6ba192
Clean up some unused variables and some unnecessary run_test functions in toolkit/components/places/tests. r=mak
https://hg.mozilla.org/mozilla-central/rev/a7f1ac6ba192
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.