1374705 - Clean up some unused variables and some unnecessary run_test functions in toolkit/components/places/tests

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement)

Description

[Mark Banner (:standard8)]

I've cleaned up a few unused vars in toolkit/components/places/tests as I was looking at bug 1094910 and found a few cases where we were getting the bookmarks or history service when we didn't need to. Hence confusing the list on that bug.

I have also cleaned up cases where we're doing:

function run_test() {
  run_next_test();
}

as these are unnecessary as xpcshell's head.js defines it for us already.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1374705 - Clean up some unused variables and some unnecessary run_test functions in toolkit/components/places/tests.

Review commit: https://reviewboard.mozilla.org/r/150966/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150966/

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8879621 [details]
Bug 1374705 - Clean up some unused variables and some unnecessary run_test functions in toolkit/components/places/tests.

https://reviewboard.mozilla.org/r/150966/#review156138

it looks great, thank you. A lot of the tests have really legacy code, but we have too many to convert.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7f1ac6ba192
Clean up some unused variables and some unnecessary run_test functions in toolkit/components/places/tests. r=mak

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a7f1ac6ba192