1094910 - Convert xpcshell-tests in toolkit/components/places/tests/bookmarks to Bookmarks.jsm API

Status: RESOLVED INCOMPLETE

(Toolkit :: Places, defect, P2)

Description

[Marco Bonardo [:mak]]

must pay attention to not dupe test from the new API

Comment 1

[[e-mail]]

search dxr with `nsINavBookmarksService`, the effected files (exclude from bookmarks/ under bug 1094903) are

toolkit/components/places/tests/autocomplete/head_autocomplete.js
toolkit/components/places/tests/history/test_removeVisits.js
toolkit/components/places/tests/unit/test_000_frecency.js
toolkit/components/places/tests/unit/test_331487.js
toolkit/components/places/tests/unit/test_331487.js
toolkit/components/places/tests/unit/test_399264_query_to_string.js
toolkit/components/places/tests/unit/test_399264_string_to_query.js
toolkit/components/places/tests/unit/test_402799.js
toolkit/components/places/tests/unit/test_405497.js
toolkit/components/places/tests/unit/test_413784.js
toolkit/components/places/tests/unit/test_418643_removeFolderChildren.js
toolkit/components/places/tests/unit/test_419792_node_tags_property.js
toolkit/components/places/tests/unit/test_433317_query_title_update.js
toolkit/components/places/tests/unit/test_433525_hasChildren_crash.js
toolkit/components/places/tests/unit/test_452777.js
toolkit/components/places/tests/unit/test_adaptive_bug527311.js
toolkit/components/places/tests/unit/test_annotations.js
toolkit/components/places/tests/unit/test_bookmarks_setNullTitle.js
toolkit/components/places/tests/unit/test_childlessTags.js
toolkit/components/places/tests/unit/test_crash_476292.js
toolkit/components/places/tests/unit/test_frecency.js
toolkit/components/places/tests/unit/test_frecency_observers.js
toolkit/components/places/tests/unit/test_getChildIndex.js
toolkit/components/places/tests/unit/test_history_sidebar.js'
toolkit/components/places/tests/unit/test_lastModified.js
toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js
toolkit/components/places/tests/unit/test_multi_word_tags.js
toolkit/components/places/tests/unit/test_null_interfaces.js
toolkit/components/places/tests/unit/test_placeURIs.js

Comment 2

[Marco Bonardo [:mak]]

(In reply to Fred Lin [:gasolin] from comment #1)
> search dxr with `nsINavBookmarksService`, the effected files (exclude from
> bookmarks/ under bug 1094903) are

this bug is only about tests under bookmarks/, maybe you wanted to post this in bug 1094903?

Btw, it's not enough to search nsINavBookmarksService, since some tests could be using PlacesUtils.bookmarks.OLDAPI... this is more problematic to search cause also the new API is in PlacesUtils.bookmarks. We may have to go test by test...

Comment 3

[Mark Banner (:standard8)]

After bug 1415835, there's still a few tests remaining that need transitioning, but I probably won't be picking them up until closer to the time we do more work on removing the async APIs.

Some notes:

- test_417228-exclude-from-backup.js
- test_417228-other-roots.js
-- insert folders into the root, the new APIs won't allow this, so we either need to drop it, or write sql injection for testing these.

- test_bookmarks_notifications,js
-- Largely async based, for some reason has one or two sync APIs in. Needs investigation.

- test_bookmarks.js
-- See bug 1403487

- test_bookmarks_treecache.js
-- Probably needs sql injection as a replacement.

- test_keywords.js
-- Probably just needs converting

- test_nsINavBookmarkObserver.js
-- Seems to be the sync version of test_bookmarks_notifications.js but needs investigating to ensure all tests are covered by the new one.

- test_sync_fields.js
-- Appears to test both sync and async APIs already.

Comment 4

[Marco Bonardo [:mak]]

At this point we will directly fix these tests when removing the APIs.