1374776 - Convert toolkit/components/places/tests/bookmarks/test_395101.js to use the new Bookmarks async API

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement)

Description

[Mark Banner (:standard8)]

Convert test cases to use new bookmark API based on bug 1094903 comment 8.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1374776 - Convert toolkit/components/places/tests/bookmarks/test_395101.js to use the new Bookmarks async API.

Review commit: https://reviewboard.mozilla.org/r/151044/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151044/

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8879695 [details]
Bug 1374776 - Convert toolkit/components/places/tests/bookmarks/test_395101.js to use the new Bookmarks async API.

https://reviewboard.mozilla.org/r/151044/#review156128

::: toolkit/components/places/tests/bookmarks/test_search_tags.js:39
(Diff revision 1)
> -  var result = histsvc.executeQuery(query, options);
> +  var result = PlacesUtils.history.executeQuery(query, options);
>    var rootNode = result.root;
>    rootNode.containerOpen = true;
>  
>    do_check_eq(rootNode.childCount, 1);
> -  do_check_eq(rootNode.getChild(0).itemId, b1);
> +  do_check_eq(rootNode.getChild(0).itemId, bookmarkId);

you may actually use .bookmarkGuid from the node and compare with the guid, so you avoid a promiseItemId call.

::: toolkit/components/places/tests/bookmarks/xpcshell.ini:48
(Diff revision 1)
>  [test_nsINavBookmarkObserver.js]
>  [test_protectRoots.js]
>  [test_removeFolderTransaction_reinsert.js]
>  [test_removeItem.js]
>  [test_savedsearches.js]
> +[test_search_tags.js]

the test should probably be moved under the "queries" folder, it's not really about "bookmarks".

Unfortunately the current tests separation is broken, apart from very recent tests for the new async APIs and unifiedcomplete, all the rest is placed "randomly", so we may try to clean it up a bit.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8879695 [details]
Bug 1374776 - Convert toolkit/components/places/tests/bookmarks/test_395101.js to use the new Bookmarks async API.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151044/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8472f434c2d
Convert toolkit/components/places/tests/bookmarks/test_395101.js to use the new Bookmarks async API. r=mak

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a8472f434c2d