Closed
Bug 1374842
Opened 7 years ago
Closed 7 years ago
stylo: Use FnvHashMap instead of HashMap for AnimationValueMap
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: hiro, Assigned: hiro)
References
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•7 years ago
|
||
On my local profile:
With HashMap
748.0ms 6.6% Servo_AnimationCompose
403.0ms 3.6% Animatable::add_weighted
171.0ms 1.5% HashMap::insert
With FnvHashMap
318.0ms 4.9% Servo_AnimationCompose
195.0ms 3.0% Animatable::add_weighted
48.0ms 0.7% HashMap::insert
Seems nearly twice as fast as HashMap.
|
|
Assignee | |
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc8c94735de16b2cce084c1ce8af816124c8650d
Thank you Emilio for the suggestion!
| Comment hidden (mozreview-request) |
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8879742 [details]
Bug 1374842 - Use FnvHashmap instead of HashMap for AnimationValueMap.
https://reviewboard.mozilla.org/r/151088/#review155944
Attachment #8879742 -
Flags: review?(emilio+bugs) → review+
|
|
Assignee | |
Comment 5•7 years ago
|
||
https://github.com/servo/servo/pull/17444
https://hg.mozilla.org/integration/autoland/rev/7f441c7a929f
Assignee: nobody → hikezoe
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•