Closed Bug 1374938 Opened 2 years ago Closed 2 years ago
Devices .ondevicechange and cam contraints are broken on Mac OSX
The code update introduced in bug 1341285 broke mediaDevices.ondevicechange on Mac OSX. It is because we are now using webrtc.org's avfoundation wrapper under the folder video_capture/objc instead of our own implementation under video_capture/mac.
It seems difficult to have a test case for device change since it is hard to simulate it. It would be nice to have a test case to avoid this kind of regression.
Rank: 25 → 15
Priority: P2 → P1
Assignee: nobody → mchiang
Duplicate of this bug: 1375321
Summary: mediaDevices.ondevicechange is broken on Mac OSX → mediaDevices.ondevicechange and cam contraints are broken on Mac OSX
(In reply to Blake Wu [:bwu][:blakewu] from comment #1) > It seems difficult to have a test case for device change since it is hard to > simulate it. It would be nice to have a test case to avoid this kind of > regression. While device changes are hard to test camera constraints might be a little bit easier. I guess the problem with the constraints is that we use the fake camera everywhere/mostly(?).
Comment on attachment 8880257 [details] Bug 1374938 - use our own avfoundation wrapper. https://reviewboard.mozilla.org/r/151614/#review156984 lgtm.
Attachment #8880257 - Flags: review?(jib) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/c846596b4cb8 use our own avfoundation wrapper. r=jib
You need to log in before you can comment on or make changes to this bug.