1374946 - Don't download things from tooltool for l10n builds

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Mike Hommey [:glandium]]

Since bug 1373150 has apparently stuck, we can stop downloading things from tooltool in l10n builds.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1374946 - Only download what's needed for l10n repacks.

As of bug 1373150, l10n repacks do not require a toolchain, so they can
stop downloading from tooltool. As a consequence, we can remove all
things related to tooltool in the harness handling those repacks, as
well as their configuration.

Review commit: https://reviewboard.mozilla.org/r/151260/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151260/

Comment 2

[Mike Hommey [:glandium]]

Hah, it busts windows because of mozmake.

Comment 3

[Mike Hommey [:glandium]]

So, we're still going to need tooltool for mozmake on windows, and for some dmg tools on cross-osx. So we can't entirely remove the tooltool support, but we can use stripped down manifests (and no manifests for linux/android).

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8879849 [details]
Bug 1374946 - Only download what's needed for l10n repacks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151260/diff/1-2/

Comment 5

[Mike Hommey [:glandium]]

Here's a try push with a smaller all-locales and a workaround for the mac bundle name on try (where l10n jobs have MOZ_UPDATE_CHANNEL=nightly, while the nightly job they depend on have MOZ_UPDATE_CHANNEL=nightly-try ; that makes them use a different mac bundle name (Nightly.app vs. FirefoxNightlyApp):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=361d466f1a2c2ea57bb3a036b431cde02a28844b

Note the l10n(l10n) bustage on mac (non-cross l10n repack) is busted because of https://hg.mozilla.org/mozilla-central/rev/89ec4b65a5f6b0ff4d47e906e1fafadb2afbc756 , not this patch ; I mentioned it on #tcmigration.

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 8879849 [details]
Bug 1374946 - Only download what's needed for l10n repacks.

https://reviewboard.mozilla.org/r/151260/#review158268

::: testing/mozharness/scripts/desktop_l10n.py:1047
(Diff revision 2)
>          dirs = self.query_abs_dirs()
>          manifest_src = os.environ.get('TOOLTOOL_MANIFEST')
>          if not manifest_src:
>              manifest_src = config.get('tooltool_manifest_src')
>          if not manifest_src:
> -            return self.warning(ERROR_MSGS['tooltool_manifest_undetermined'])
> +            return

I'm happy to keep a warning here (short term) It helps identify what happened. Was there a reason other than log spew you stripped this?

Comment 7

[Mike Hommey [:glandium]]

(In reply to Justin Wood (:Callek) from comment #6)
> Comment on attachment 8879849 [details]
> Bug 1374946 - Only download what's needed for l10n repacks.
> 
> https://reviewboard.mozilla.org/r/151260/#review158268
> 
> ::: testing/mozharness/scripts/desktop_l10n.py:1047
> (Diff revision 2)
> >          dirs = self.query_abs_dirs()
> >          manifest_src = os.environ.get('TOOLTOOL_MANIFEST')
> >          if not manifest_src:
> >              manifest_src = config.get('tooltool_manifest_src')
> >          if not manifest_src:
> > -            return self.warning(ERROR_MSGS['tooltool_manifest_undetermined'])
> > +            return
> 
> I'm happy to keep a warning here (short term) It helps identify what
> happened. Was there a reason other than log spew you stripped this?

ERROR_MSGS doesn't contain tooltool_manifest_undetermined in that file.

Comment 8

[Mike Hommey [:glandium]]

That is, that code path was failing instead of warning.

Do you prefer that I add it?

Comment 9

[Justin Wood (:Callek)]

(In reply to Mike Hommey [:glandium] from comment #8)
> That is, that code path was failing instead of warning.
> 
> Do you prefer that I add it?

Either way is fine by me.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98e8d5976778
Only download what's needed for l10n repacks. r=Callek

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/98e8d5976778