137495 - TestDeque tries to delete a static class

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[timeless]

Ok, so my hastilly written test app wasn't really tested

The result is that you get:
Debug Asserts from the runtime saying you're doing something stupid
on freebsd, they look like this:
TestDeque in free(): warning: junk pointer, too low to make sense.
An optional crash that is derived from this

nsDeque::ForEach(nsDequeFunctor & {...}) line 393 + 21 bytes
nsDeque::Erase() line 163
nsDeque::~nsDeque() line 120
_TestDeque::OriginalFlaw() line 144 + 29 bytes
_TestDeque::SelfTest() line 71 + 8 bytes
_TestDeque::_TestDeque() line 49
$E1() line 59 + 13 bytes
$E2() + 8 bytes
_initterm(void (void)* * 0x00406104 $S3, void (void)* * 0x00406208 ___xc_z) 
line 525
mainCRTStartup() line 274 + 15 bytes

the line:
    aFunctor(ObjectAt(i));
the problem:
-	aFunctor	{...}
+	__vfptr	0xdddddddd
(windows actually decided to free my static class ...)

Comment 1

[timeless]

Attachment: split the deallocator into its own class, and use it correctly

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 79236 [details] [diff] [review]
split the deallocator into its own class, and use it correctly

>+class _Dealloc: public nsDequeFunctor{
				      ^^^
as per on IRC, add a space up there and r=caillon

Comment 3

[Darin Fisher]

Comment on attachment 79236 [details] [diff] [review]
split the deallocator into its own class, and use it correctly

rs=darin

Comment 4

[timeless]

fixed in r1.4