727686 - xpcom/tests/TestDeque.cpp:55:19: warning: ‘sTestDeque’ defined but not used [-Wunused-variable]

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Daniel Holbert [:dholbert]]

xpcom/tests/TestDeque.cpp:55:19: warning: ‘sTestDeque’ defined but not used [-Wunused-variable]

This variable is declared as
> 55 static _TestDeque sTestDeque;

It was added in bug 137495, but it was never used, even in the patch that added it.

It looks like this file declares another _TestDeque object inside of main(), and that's the object that it actually uses.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 2

[Daniel Holbert [:dholbert]]

(Note: this test has apparently been disabled for a while, and it was recently re-enabled here:
 http://hg.mozilla.org/mozilla-central/diff/6012abe637a8/xpcom/tests/Makefile.in
)

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 597639 [details] [diff] [review]
fix v1

(bouncing r? to cpearce, since he touched this test in the last month rather than ~10 years ago. :)  timeless, feel free to steal review back if you happen to get to it first.)

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 597639 [details] [diff] [review]
fix v1

Review of attachment 597639 [details] [diff] [review]:
-----------------------------------------------------------------

Rubber Stamp Engaged.

Comment 5

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6d7033dc6480

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6d7033dc6480