Closed Bug 1374996 Opened 7 years ago Closed 7 years ago

stylo: -moz-prefixed values of -moz-user-select are incorrectly computed to unprefixed values

Categories

(Core :: CSS Parsing and Computation, enhancement)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: xidorn, Assigned: xidorn)

References

(Blocks 1 open bug)

Details

In Stylo, for "-moz-user-select" property, value "-moz-all" would be computed to "all", and value "-moz-text" would be computed to "text", which is wrong. "-moz-{all,text}" and "{all,text}" have different meaning for Gecko layout system. What I know is "-moz-all" overrides any "none" inside, while "all" doesn't. And "text" will be overridden by any "none" or "all" from ancestor, while "-moz-text" won't. The rule is a bit complicated, but anyway, they are different values, and shouldn't be computed to the same value. I suspect this is the root reason of some failures in mochitests of editor.
It seems related code are all generated from mako, so probably we would need to add some special case or something. Manish, what do you think?
Flags: needinfo?(manishearth)
Specifically, I think this is the reason of failures in editor/libeditor/tests/test_bug1318312.html
Yeah, makes sense. `helpers:single_keyword_computed` exists for when ToComputedValue is nontrivial.
Flags: needinfo?(manishearth)
Have a patch.
Assignee: nobody → xidorn+moz
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.