Open
Bug 1320841
(stylo-mochitest)
Opened 7 years ago
Updated 1 year ago
[meta] Pass all mochitests for Stylo
Categories
(Core :: CSS Parsing and Computation, defect, P5)
Core
CSS Parsing and Computation
Tracking
()
REOPENED
People
(Reporter: manishearth, Unassigned)
References
(Depends on 1 open bug)
Details
(Keywords: meta)
Attachments
(2 files, 2 obsolete files)
58 bytes,
text/x-review-board-request
|
Details | |
59.64 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8815129 [details] Bug 1320841 - Re-enable mochitests for Stylo builds; https://reviewboard.mozilla.org/r/96126/#review96706 I would prefer we create a subset of mochitests to run for stylo. Probably create a new test task called mochitest-stylo and gradually move tests we care about into the list until the implementation is good enough to be run on all. Unlike reftest which is mainly only used to test layout system, mochitest is used to test all kinds of things, so it could be too noisy to enable for now. I can try to create that new test task.
Attachment #8815129 -
Flags: review?(xidorn+moz)
Updated•7 years ago
|
Depends on: stylo-style-mochitest
Updated•7 years ago
|
Blocks: stylo-nightly
Priority: -- → P2
Updated•7 years ago
|
Priority: P2 → P5
Reporter | ||
Comment 3•7 years ago
|
||
We already run mochitests.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment 4•7 years ago
|
||
Nope. We only run a very limited set of mochitests at the moment (the style system mochitests). We should probably consider enabling more, but I'm still not sure whether enabling wider range of mochitests are worth the work at this stage. By "the work", I mean triaging the reason of the failures. We probably should still be focusing on reducing failures in style system mochitests.
Assignee: manishearth → nobody
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 5•7 years ago
|
||
I plan to enable chrome and browser style system mochitests soonish, as well as enabling them with e10s.
Comment 6•7 years ago
|
||
(In reply to Xidorn Quan [:xidorn] (UTC+10) from comment #5) > I plan to enable chrome and browser style system mochitests soonish, as well > as enabling them with e10s. Can you file a bug on this? This has high uncertainty-reduction value, so should probably be P1.
Comment 7•7 years ago
|
||
(In reply to Bobby Holley (:bholley) (busy with Stylo) from comment #6) > Can you file a bug on this? This has high uncertainty-reduction value, so > should probably be P1. Bug 1346047 and bug 1346048.
Comment 8•7 years ago
|
||
April 24 run of ALL mochitests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=125e0d61d3353476bdde95cc433707c03e8f4349 Here are the summary: FAIL 681 PASS 2 TIMEOUT 10 CRASH 17
Comment 9•7 years ago
|
||
Comment 10•7 years ago
|
||
Comment 11•7 years ago
|
||
(In reply to Shing Lyu [:shinglyu] from comment #9) > Created attachment 8860842 [details] > List of tests with unexpected behavior Nice! Looks like the lion's share of the failures (asides from the ones in layout/style) are in devtools and animation code, both of which we have bugs on. We should be able to make progress on these in the coming weeks.
Comment 12•7 years ago
|
||
May 3 test results: Devtools 342 Misc layout 145 Misc 51 DOM 48 Animation 32 Crashes 16 Timeout 10 Grid 6 Forms 5 Canvas 3 Error 1 There are quite a few in the layout folder, but seems to came from many different root causes.
Comment 13•7 years ago
|
||
May 3 all mochitest results
Attachment #8860842 -
Attachment is obsolete: true
Attachment #8860843 -
Attachment is obsolete: true
Comment 14•7 years ago
|
||
(In reply to Shing Lyu [:shinglyu] from comment #12) > May 3 test results: Try link: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8832e1abf7264d357750d994230dee1c826818d2
Updated•7 years ago
|
Attachment #8865289 -
Attachment is patch: true
Attachment #8865289 -
Attachment mime type: text/markdown → text/plain
Comment 16•7 years ago
|
||
This is the latest try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ac549771fc9d7c16447619f4df190664adc74e6
Flags: needinfo?(shing.lyu)
Comment 17•7 years ago
|
||
The result from comment 16 shows some failures in dom/base/test/test_intersectionobservers.html but I cannot reproduce them in my local build. Maybe they have been fixed somehow, or they are failing on Linux specifically.
Comment 18•7 years ago
|
||
Same for * dom/base/test/test_mutationobserver_anonymous.html * dom/base/test/test_reentrant_flush.html * dom/base/test/test_script_loader_js_cache.html * dom/base/test/test_timer_flood.html
Comment 19•7 years ago
|
||
dom/security/test/csp/test_inlinestyle.html also works as expected locally.
Comment 20•7 years ago
|
||
The following tests seem to work fine locally: * editor/libeditor/tests/test_dragdrop.html * layout/base/tests/test_bug416896.html And for layout/base/tests/test_reftests_with_caret.html, only bug966992-{1,2,3}.html are failing because of bug 1375374. Other subtests work just fine.
Comment 21•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=95094b7ec64fb30dc126f2f03f3520d03f3dffa5
Comment 22•7 years ago
|
||
Turning this into a meta bug. I'll open another bug for retiring stylo-failures.md and enabling all mochitests.
Keywords: meta
Summary: Re-enable mochitests for Stylo builds → [meta] Pass all mochitests for Stylo
Updated•7 years ago
|
Alias: stylo-mochitest
Updated•7 years ago
|
Depends on: stylo-devtools-tests
Depends on: 1393819
Depends on: 1394887
Updated•7 years ago
|
Depends on: stylo-mochitest-crashes
Updated•1 year ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•