1375199 - [aws-provisioner] Remove required scopesets from aws-provisioner workerType endpoint

Status: RESOLVED FIXED

(Taskcluster :: Services, enhancement, P5)

Description

[Pete Moore [:pmoore][:pete]]

Only when bug 1375197 is resolved fixed, we should open up the worker type definitions by changing the following API point to require no scopes:

https://docs.taskcluster.net/reference/integrations/aws-provisioner/references/api#workerType

Comment 1

[John Ford [:jhford] CET/CEST Berlin Time]

Worth mentioning is that even though we currently allow a list of scopes in the worker type definition, these scopes actually have no purpose and aren't part of any credentials issued by the provisioner.

Comment 2

[Pete Moore [:pmoore][:pete]]

(In reply to John Ford [:jhford] CET/CEST Berlin Time from comment #1)
> Worth mentioning is that even though we currently allow a list of scopes in
> the worker type definition, these scopes actually have no purpose and aren't
> part of any credentials issued by the provisioner.

Thanks John.

This bug is more about removing the required scope aws-provisioner:view-worker-type:<workerType> from the workerType API endpoint (i.e. requiring no auth when hitting https://aws-provisioner.taskcluster.net/v1/worker-type/<workerType>).

I think the issue about the scopes property of the worker type definition no longer being used/required is tracked in bug 1375228.

Comment 3

[Chris Cooper [:coop] (he/him)]

Found in triage.

Pete: you were going to do something with this batch of bugs, IIRC.

Comment 4

[John Ford [:jhford] CET/CEST Berlin Time]

We are working to move our provisioning to the new worker manager design.  This design does not have any provisioner secrets in it and will not have worker types protected by scopes.  I'm marking this P5 because it's low priority to fix in the Aws-Provisioner codebase and dependent on a much larger project of removing provisioner secrets.

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/taskcluster/aws-provisioner/pull/202