Closed Bug 1375319 Opened 4 years ago Closed 2 years ago

Dispatch fullscreen events to element first rather than dispatch to document directly

Categories

(Core :: DOM: Core & HTML, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete, Whiteboard: [webcompat])

Attachments

(3 files)

WebKit/Blink currently dispatches fullscreen events to elements, which makes sense, and matches our initial proposal of Fullscreen API [1].

It was not implemented that way probably because the current Gecko approach is easier to implement.

The spec has been changed to dispatch those events to element, and fallback to document in cases at whatwg/fullscreen#90.


[1] https://wiki.mozilla.org/Gecko:FullScreenAPI#fullscreenchange_event
Priority: -- → P2
This is indeed something we want to do before we unprefix fullscreen.
Blocks: 1269276
Flags: webcompat?
Whiteboard: [webcompat]
Blocks: 1436334
Xidorn, are you planning to do this soonish?  If not, I can probably steal it.
Flags: needinfo?(xidorn+moz)
No, I don't currently have a plan, so if you want to work on this, go ahead. Thanks!
Flags: needinfo?(xidorn+moz)
I'm going to take this as Chrome is going to ship unprefixed Fullscreen API, and I think we should try shipping that as soon as possible as well.
Assignee: nobody → xidorn+moz
Depends on: 1489376
Depends on: 1489385
Some steps in file_fullscreen-api.html are adjusted in order to test
the behavior that the event is correctly dispatched to the document
when element is disconnected.

Depends on D5415
Comment on attachment 9007749 [details]
Bug 1375319 part 1 - Make DispatchTrustedEvent able to dispatch composed event and have fullscreen events composed. r=smaug

Olli Pettay [:smaug] has approved the revision.
Attachment #9007749 - Flags: review+
Comment on attachment 9007750 [details]
Bug 1375319 part 2 - Use a global const for element to fullscreen in file_fullscreen-api test. r=smaug

Olli Pettay [:smaug] has approved the revision.
Attachment #9007750 - Flags: review+
Blocks: 1188256
Comment on attachment 9007751 [details]
Bug 1375319 part 3 - Try dispatching fullscreen events to element first rather than document. r=smaug

Olli Pettay [:smaug] has approved the revision.
Attachment #9007751 - Flags: review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1ad49dc53686
part 1 - Make DispatchTrustedEvent able to dispatch composed event and have fullscreen events composed. r=smaug
https://hg.mozilla.org/integration/autoland/rev/8a57ee2c6b31
part 2 - Use a global const for element to fullscreen in file_fullscreen-api test. r=smaug
https://hg.mozilla.org/integration/autoland/rev/f11d81a58cde
part 3 - Try dispatching fullscreen events to element first rather than document. r=smaug
Depends on: 1491192
Keywords: dev-doc-needed
Depends on: 1491787
Added to Firefox 64 for developers.
Duplicate of this bug: 1507443
You need to log in before you can comment on or make changes to this bug.