Closed Bug 1489376 Opened 5 years ago Closed 5 years ago

Fullscreen events should be dispatched in tree order

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1489376 - Dispatch fullscreen events in tree order. r=smaug
46 bytes, text/x-phabricator-request
smaug
: review+
Details | Review 
Currently, when entering fullscreen, we dispatch the event in tree order, but when exiting fullscreen, we dispatch in the reverse tree order (because it makes more sense that innermost one is the earliest to exit fullscreen).

However, since then the spec has been revised to take multi-process document into account. Since fullscreen events are always synced with flush, their relative order becomes less a problem, and it may be easier to dispatch them in a given order for both directions of fullscreen change.

(I don't think this needs to block shipping unprefixed fullscreen, though.)
Priority: -- → P3
It seems this would actually make it easier to implement bug 1375319.
Assignee: nobody → xidorn+moz
Blocks: 1375319
Comment on attachment 9007654 [details]
Bug 1489376 - Dispatch fullscreen events in tree order. r=smaug

Olli Pettay [:smaug] has approved the revision.
Attachment #9007654 - Flags: review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6b1be7db8f0f
Dispatch fullscreen events in tree order. r=smaug
https://hg.mozilla.org/mozilla-central/rev/6b1be7db8f0f
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox64: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.