1375376 - Write a test for clicking on addbook: link from vCard displayed inline (test for bug 1374779)

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1374779 +++

Write a test for clicking on addbook: link from vCard displayed inline

STR:
Set attachments to display inline.
Import and open message from attachment 8879692 [details].
Click on the vCard link.

Expected result:
chrome://messenger/content/addressbook/abNewCardDialog.xul opens.

Comment 1

[:aceman]

Attachment: patch

This should do it. I have confirmed backing out bug 1374779 makes the test fail.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 8882836 [details] [diff] [review]
patch

Review of attachment 8882836 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Now over to bug 1352740 and bug 1352739? ;-)

::: mail/test/mozmill/message-window/test-vcard-actions.js
@@ +4,5 @@
> +
> +/**
> + * Tests for attached vcards.
> + */
> +

Please add:
// make SOLO_TEST=message-window/test-vcard-actions.js mozmill-one

@@ +49,5 @@
> +  // Check new card was created from the vcard.
> +  newcards = get_cards_in_all_address_books_for_email("[e-mail]");
> +  assert_equals(newcards.length, 1);
> +
> +  msgc.sleep(5000);

Why sleep here?

Comment 3

[:aceman]

Attachment: patch v1.1

Debugging leftover :)

Comment 4

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/7d0b8cd8b49d7e192ecc10c0c70a13af6a2a8f87