137551 - Edit|Save Form Info not working

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

1) fill in some data in above url (e.g. name)
2) click Edit|Save Form Info

you get a dialog "Data captured", but it isn't. The data doesn't appear in
Tools|Form Manager|Edit Form Info, and Edit|Fill In Form is greyed out.

This is on Linux, 2002041507

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

smoketest blocker (B.26 fails)

Comment 2

[Stephen P. Morse]

Is this a linux-only problem or can you reproduce it on win32?

It's working fine on my win32 build from 4-4.  I'm currently in the process of 
pulling and building a new win32 build, also a linux build so I can test 
further.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

I'm sorry, I can't test win32...

Comment 4

[Samir Gehani]

Using a Win32 commercial trunk build dated 2002041503 I can't reproduce this
problem.  The data is saved and vewiable under ``Other Saved Information'' >
``Concatenations'' in the form manager dialog.

Using a Linux mozilla trunk build dated 2002041507 I  *can*  reproduce this
problem with the same symptoms manifesting as originally reported.

Using a Linux mozilla 1.0.0 branch build dated 2002041409 I  *can*  reproduce
this problem with the same symptoms manifesting as originally reported.

Comment 5

[Stephen P. Morse]

Just an update.  No progress yet but I now have an up-to-date linux tree so I 
can start investigating.

Comment 6

[Andreas Otte]

I can also verify this problem on the mozilla 1.0 branch. This should block bug
134771.

Comment 7

[kysmith0 (gone)]

downgrading to critical so we can open tree

Comment 8

[Stephen P. Morse]

Here's an update, scant as it is.  Something weird is happening at this point:

wallet.cpp: line 2906

     const char* valueCString = NS_ConvertUCS2toUTF8(value).get();
     nsCAutoString oldValue;

If I add print statements as follows:

     const char* valueCString = NS_ConvertUCS2toUTF8(value).get();
     printf("before: %s\n",valueCString);
     nsCAutoString oldValue;
     printf("after: %s\n",valueCString);

then the first print statement prints out the correct value for valueCString but 
the second print statement prints an empty string.  I don't understand this yet, 
but this is the point at which the program goes astray.

Comment 9

[Heikki Toivonen (remove -bugzilla when emailing directly)]

NS_ConvertUCS2toUTF8(value).get() gives you a ref to a temporary, no wonder it
does not work!

Comment 10

[Stephen P. Morse]

Attachment: get rid of ref to temporary

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 79361 [details] [diff] [review]
get rid of ref to temporary

sr=scc
(from asa's machine)

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 79361 [details] [diff] [review]
get rid of ref to temporary

a=asa (on behalf of drivers) for checkin to the 1.0 branch. trunk too.
This is a smoketest blocker for branch and trunk. scc's sr= is sufficient
review to land this. Please land ASAP. Thanks.

Comment 13

[Stephen P. Morse]

Checked into both branch and trunk

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

Couldn't you optimize this by changing
+  nsCAutoString valueCString = NS_ConvertUCS2toUTF8(value);
to
+  NS_ConvertUCS2toUTF8 valueCString(value);
?

Comment 15

[Jaime Rodriguez, Jr.]

gonna add an adt1.0.0+, sicne this has already been checked into the 1.0 branch,
and was a smoketest blocker.

Comment 16

[Terri Preston]

Verified fixed linux trunk build 2002041609 and branch build 2002041615