1375688 - HTMLFormElement does unnecessary hashtable lookups

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Comment 1

[Mats Palmgren (inactive)]

Attachment: Use Lookup instead of Get+Remove/Put, and LookupForAdd instead of Get+Put, to avoid unnecessary hashtable lookups

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3be13bca20672995fe600211b3a9f15799305931

Comment 2

[Mats Palmgren (inactive)]

Look like you forgot this one?

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8880624 [details] [diff] [review]
Use Lookup instead of Get+Remove/Put, and LookupForAdd instead of Get+Put, to avoid unnecessary hashtable lookups

Review of attachment 8880624 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, I thought this review was more complicated than it actually was for some reason.

::: dom/html/HTMLFormElement.cpp
@@ +1450,5 @@
>    if (content) {
>      return NS_OK;
>    }
>  
> +  nsCOMPtr<nsIDOMNodeList> nodeList(do_QueryInterface(entry.Data().get()));

In the do_QueryInterface call above, you just accessed entry.Data(); can we do the same thing here as well?

Comment 4

[Mats Palmgren (inactive)]

Yes, bug 1375691 changes this line and drops the get().

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b46c5332f7b
Use Lookup instead of Get+Remove/Put, and LookupForAdd instead of Get+Put, to avoid unnecessary hashtable lookups.  r=froydnj

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4b46c5332f7b