nsDocument::GetBoxObjectFor/ClearBoxObjectFor does unnecessary hashtable lookups

RESOLVED FIXED in Firefox 56

Status

()

Core
XUL
P2
normal
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: mats, Assigned: mats)

Tracking

({perf})

Trunk
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

7 months ago
Depends on: 1375698
(Assignee)

Comment 1

7 months ago
Created attachment 8880635 [details] [diff] [review]
Use LookupForAdd instead of Get+Put, and Lookup instead of GetWeak+Remove, to avoid unnecessary hashtable lookups

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3be13bca20672995fe600211b3a9f15799305931
Attachment #8880635 - Flags: review?(nfroyd)

Updated

7 months ago
Attachment #8880635 - Flags: review?(nfroyd) → review+

Comment 2

7 months ago
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c14db1e8d717
Use LookupForAdd instead of Get+Put, and Lookup instead of GetWeak+Remove, to avoid unnecessary hashtable lookups.  r=froydnj

Comment 3

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c14db1e8d717
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.