Closed Bug 1375696 Opened 8 years ago Closed 8 years ago

nsDocument::GetBoxObjectFor/ClearBoxObjectFor does unnecessary hashtable lookups

Categories

(Core :: XUL, enhancement, P2)

Product:
Core
Component:
XUL
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)

References

Details

(Keywords: perf)

Attachments

(1 file)

Use LookupForAdd instead of Get+Put, and Lookup instead of GetWeak+Remove, to avoid unnecessary hashtable lookups
2.39 KB, patch
froydnj
: review+
Details | Diff | Splinter Review
No description provided.
Depends on: 1375698
Attachment #8880635 - Flags: review?(nfroyd) → review+
Pushed by mpalmgren@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c14db1e8d717 Use LookupForAdd instead of Get+Put, and Lookup instead of GetWeak+Remove, to avoid unnecessary hashtable lookups. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/c14db1e8d717
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: