Fix Advanced Layers browser-chrome crash in SetCompositorAnimations

RESOLVED FIXED in Firefox 56

Status

()

Core
Graphics: Layers
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: dvander, Assigned: dvander)

Tracking

40 Branch
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

Example: https://treeherder.mozilla.org/#/jobs?repo=try&author=danderson@mozilla.com&selectedJob=108802160

Have not been able to reproduce locally, but I have a loan machine from another bug.
Created attachment 8881113 [details] [diff] [review]
fix

Whoops. I forgot some layers boilerplate. I added a MOZ_RELEASE_ASSERT that we don't change layer manager types, but theoretically it could happen? I'm not sure how to handle that yet.
Attachment #8881113 - Flags: review?(matt.woodrow)
Attachment #8881113 - Flags: review?(matt.woodrow) → review+

Comment 2

11 months ago
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9db369ba372c
Implement LayerMLGPU::SetLayerManager. (bug 1375759, r=mattwoodrow)

Comment 3

11 months ago
Backout by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7da6c9907099
Backed out changeset 9db369ba372c for unused mComputedDrawRegion. r=backout

Comment 4

11 months ago
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71125aa849d3
Implement LayerMLGPU::SetLayerManager. (bug 1375759, r=mattwoodrow)

Comment 5

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/71125aa849d3
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.