Closed Bug 1376097 Opened 3 years ago Closed 3 years ago
[hamburger panel] Print menu item label should have ellipsis
This item doesn't immediately print the page and should therefore have an ellipsis.
Whiteboard: [photon-structure][triage] → [reserve-photon-structure]
Why was this put in the reserve? Please don't tell me that it can ship as-is because it was designed this way. Is this another case of Mac specifics (e.g. no print preview) spilling over to other platforms?
(In reply to Dão Gottwald [::dao] from comment #1) > Why was this put in the reserve? Please don't tell me that it can ship as-is > because it was designed this way. Is this another case of Mac specifics > (e.g. no print preview) spilling over to other platforms? Because this isn't a regression - print in the hamburger panel already behaves this way and already doesn't have an ellipsis, also on Linux/Windows, and the presence or absence of the '...' isn't something that needs to block release anyway. It's just not as important as everything else we're having to do.
This bug can be fixed by replacing &printButton.label; with &printCmd.label; in browser/components/customizableui/content/panelUI.inc.xul: http://searchfox.org/mozilla-central/rev/a1aa8b434a59df1b7530fee1ae78f11befb5c5dc/browser/components/customizableui/content/panelUI.inc.xul#676
Whiteboard: [reserve-photon-structure] → [reserve-photon-structure][lang=xul]
Attaching a patch. Sorry, I couldn’t make sense of MozReview.
Comment on attachment 8883812 [details] [diff] [review] Proposed patch Looks good. Thanks! (In reply to Adolfo Jayme from comment #4) > Created attachment 8883812 [details] [diff] [review] > Proposed patch > > Attaching a patch. Sorry, I couldn’t make sense of MozReview. That's fine, afaik we're getting rid of MozReview anyway in favor of something else.
Attachment #8883812 - Flags: review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/788774d77bab Use ellipsis in hamburger menu’s Print command. r=dao
Verified with Windows 10 64bit, Mac OS X 10.11, Ubuntu 16.04 64bit using Nightly 58.0a1 (64-bit) as of this date.
You need to log in before you can comment on or make changes to this bug.