Closed Bug 1376097 Opened 7 years ago Closed 7 years ago

[hamburger panel] Print menu item label should have ellipsis

Categories

(Firefox :: Menus, defect, P1)

Product:
Firefox
Component:
Menus
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 56
Iteration:
56.2 - Jul 10
Tracking Flags:
Tracking Status
firefox56 --- fixed
firefox58 --- verified

People

(Reporter: dao, Assigned: fitojb, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [reserve-photon-structure][lang=xul])

Attachments

(1 file)

Proposed patch
950 bytes, patch
dao
: review+
Details | Diff | Splinter Review
This item doesn't immediately print the page and should therefore have an ellipsis.
Whiteboard: [photon-structure][triage] → [reserve-photon-structure]
See Also: → 1028230
Flags: qe-verify?
Priority: -- → P3
Flags: qe-verify? → qe-verify+
QA Contact: gwimberly
Why was this put in the reserve? Please don't tell me that it can ship as-is because it was designed this way. Is this another case of Mac specifics (e.g. no print preview) spilling over to other platforms?
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Dão Gottwald [::dao] from comment #1) > Why was this put in the reserve? Please don't tell me that it can ship as-is > because it was designed this way. Is this another case of Mac specifics > (e.g. no print preview) spilling over to other platforms? Because this isn't a regression - print in the hamburger panel already behaves this way and already doesn't have an ellipsis, also on Linux/Windows, and the presence or absence of the '...' isn't something that needs to block release anyway. It's just not as important as everything else we're having to do.
Flags: needinfo?(gijskruitbosch+bugs)
This bug can be fixed by replacing &printButton.label; with &printCmd.label; in browser/components/customizableui/content/panelUI.inc.xul: http://searchfox.org/mozilla-central/rev/a1aa8b434a59df1b7530fee1ae78f11befb5c5dc/browser/components/customizableui/content/panelUI.inc.xul#676
Mentor: dao+bmo
Keywords: good-first-bug
Whiteboard: [reserve-photon-structure] → [reserve-photon-structure][lang=xul]
Attached patch Proposed patch — — Splinter Review
Attaching a patch. Sorry, I couldn’t make sense of MozReview.
Comment on attachment 8883812 [details] [diff] [review] Proposed patch Looks good. Thanks! (In reply to Adolfo Jayme from comment #4) > Created attachment 8883812 [details] [diff] [review] > Proposed patch > > Attaching a patch. Sorry, I couldn’t make sense of MozReview. That's fine, afaik we're getting rid of MozReview anyway in favor of something else.
Attachment #8883812 - Flags: review+
Assignee: nobody → fitojb
Priority: P3 → P1
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/788774d77bab Use ellipsis in hamburger menu’s Print command. r=dao
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/788774d77bab
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Iteration: --- → 56.2 - Jul 10
Verified with Windows 10 64bit, Mac OS X 10.11, Ubuntu 16.04 64bit using Nightly 58.0a1 (64-bit) as of this date.
status-firefox58: --- → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: