Closed Bug 1376235 Opened 5 years ago Closed 4 years ago

PermissionAvaliable should be PermissionAvailable

Categories

(Core :: Permission Manager, defect, P5)

defect

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox59 --- fixed

People

(Reporter: aryx, Assigned: prathiksha, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [good first bug][lang=c++])

Attachments

(1 file, 4 obsolete files)

https://hg.mozilla.org/mozilla-central/rev/e9e4b447bf87 from bug 1353179 added PermissionAvaliable. This should be PermissionAvailable.

(There are 126 matches for 'avaliable' in mozilla-central.
These occurrences need to be fixed up: https://searchfox.org/mozilla-central/search?q=PermissionAvaliable&case=false&regexp=false&path=
Mentor: jhofmann
Keywords: good-first-bug
Priority: -- → P5
Whiteboard: [good first bug][lang=c++]
Assignee: nobody → prathikshaprasadsuman
Status: NEW → ASSIGNED
Attached file nsPermissionManager.cpp (obsolete) —
Dear developers,
           I have corrected all spellings for one file, review it once, if it is correct I will do it for all the remaining files.
Attached patch nsPermissionManager.h (obsolete) — Splinter Review
Please do check once, if correct I will do it for the remaining files.
Attachment #8935416 - Attachment is obsolete: true
Attachment #8935656 - Flags: review?(jhofmann)
Attached patch nsPermissionManager.cpp (obsolete) — Splinter Review
I have corrected all the spellings, review it once.
Attachment #8935657 - Flags: review?(jhofmann)
Assignee: prathikshaprasadsuman → nobody
Status: ASSIGNED → NEW
Hi Ajinkya, sorry for the delay. Thanks for picking up this patch (note that Prathiksha was assigned to it already but she graciously unassigned herself, thanks!).

I'll need to you to attach a patch with your changes instead of the changed files. You can create a patch by running "hg commit" or "git commit", depending on what you're using. There's a lot more detail to be found here: http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html

Let me know if you have any questions!
Assignee: nobody → narnawareajinkya
Status: NEW → ASSIGNED
Attachment #8935656 - Flags: review?(jhofmann)
Attachment #8935657 - Flags: review?(jhofmann)
Sorry for The delay. Regards!
Comment on attachment 8938711 [details] [diff] [review]
Dear developer . I have attached the patch.  Please do verify whether it is correct.

Review of attachment 8938711 [details] [diff] [review]:
-----------------------------------------------------------------

Unfortunately this patch is missing the changes from the .cpp file :/

You might need to add the changes again and use hg commit --amend to overwrite your patch? :)
Attachment #8938711 - Flags: review?(jhofmann)
Hi Ajinkya,

are you still planning to work on this? I'm happy to help you get the patch right (I'm also on IRC, e.g. in the #fx-team channel, see here: https://wiki.mozilla.org/IRC), if you're still interested.

Thanks!
Flags: needinfo?(narnawareajinkya)
Status: ASSIGNED → NEW
Flags: needinfo?(narnawareajinkya)
Assignee: narnawareajinkya → prathikshaprasadsuman
Status: NEW → ASSIGNED
Attachment #8938711 - Attachment is obsolete: true
Attachment #8935657 - Attachment is obsolete: true
Attachment #8935656 - Attachment is obsolete: true
Comment on attachment 8943181 [details]
Bug 1376235 - Change PermissionAvaliable to PermissionAvailable.

https://reviewboard.mozilla.org/r/213524/#review219630

Looks good, thanks!

::: extensions/cookie/nsPermissionManager.h:366
(Diff revision 1)
>    nsresult
>    RemoveAllModifiedSince(int64_t aModificationTime);
>  
>    /**
>     * Returns false if this permission manager wouldn't have the permission
>     * requested avaliable.

nit: also mis-spelled in the comments :)

::: extensions/cookie/nsPermissionManager.h:369
(Diff revision 1)
>    /**
>     * Returns false if this permission manager wouldn't have the permission
>     * requested avaliable.
>     *
>     * If aType is nullptr, checks that the permission manager would have all
>     * permissions avaliable for the given principal.

and here
Attachment #8943181 - Flags: review?(jhofmann) → review+
Comment on attachment 8943181 [details]
Bug 1376235 - Change PermissionAvaliable to PermissionAvailable.

https://reviewboard.mozilla.org/r/213524/#review219632

::: extensions/cookie/nsPermissionManager.cpp:3372
(Diff revision 1)
>      nsAutoCString permissionKey;
>      // NOTE: GetKeyForPermission accepts a null aType.
>      GetKeyForPermission(aPrincipal, aType, permissionKey);
>  
>      // If we have a pending promise for the permission key in question, we don't
>      // have the permission avaliable, so report a warning and return false.

here, too
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7b66479caadb
Change PermissionAvaliable to PermissionAvailable. r=johannh
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7b66479caadb
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.