1376235 - PermissionAvaliable should be PermissionAvailable

Status: RESOLVED FIXED

(Core :: Permission Manager, defect, P5)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e9e4b447bf87 from bug 1353179 added PermissionAvaliable. This should be PermissionAvailable.

(There are 126 matches for 'avaliable' in mozilla-central.

Comment 1

[Johann Hofmann [:johannh]]

These occurrences need to be fixed up: https://searchfox.org/mozilla-central/search?q=PermissionAvaliable&case=false&regexp=false&path=

Comment 2

[Ajinkya Narnaware]

Attachment: nsPermissionManager.cpp

Dear developers,
           I have corrected all spellings for one file, review it once, if it is correct I will do it for all the remaining files.

Comment 3

[Ajinkya Narnaware]

Attachment: nsPermissionManager.h

Please do check once, if correct I will do it for the remaining files.

Comment 4

[Ajinkya Narnaware]

Attachment: nsPermissionManager.cpp

I have corrected all the spellings, review it once.

Comment 5

[Johann Hofmann [:johannh]]

Hi Ajinkya, sorry for the delay. Thanks for picking up this patch (note that Prathiksha was assigned to it already but she graciously unassigned herself, thanks!).

I'll need to you to attach a patch with your changes instead of the changed files. You can create a patch by running "hg commit" or "git commit", depending on what you're using. There's a lot more detail to be found here: http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html

Let me know if you have any questions!

Comment 6

[Ajinkya Narnaware]

Attachment: Dear developer . I have attached the patch. Please do verify whether it is correct.

Comment 7

[Ajinkya Narnaware]

Sorry for The delay. Regards!

Comment 8

[Johann Hofmann [:johannh]]

Comment on attachment 8938711 [details] [diff] [review]
Dear developer . I have attached the patch.  Please do verify whether it is correct.

Review of attachment 8938711 [details] [diff] [review]:
-----------------------------------------------------------------

Unfortunately this patch is missing the changes from the .cpp file :/

You might need to add the changes again and use hg commit --amend to overwrite your patch? :)

Comment 9

[Johann Hofmann [:johannh]]

Hi Ajinkya,

are you still planning to work on this? I'm happy to help you get the patch right (I'm also on IRC, e.g. in the #fx-team channel, see here: https://wiki.mozilla.org/IRC), if you're still interested.

Thanks!

Comment 10

[:prathiksha]

Attachment: Bug 1376235 - Change PermissionAvaliable to PermissionAvailable.

Review commit: https://reviewboard.mozilla.org/r/213524/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/213524/

Comment 11

[Johann Hofmann [:johannh]]

Comment on attachment 8943181 [details]
Bug 1376235 - Change PermissionAvaliable to PermissionAvailable.

https://reviewboard.mozilla.org/r/213524/#review219630

Looks good, thanks!

::: extensions/cookie/nsPermissionManager.h:366
(Diff revision 1)
>    nsresult
>    RemoveAllModifiedSince(int64_t aModificationTime);
>  
>    /**
>     * Returns false if this permission manager wouldn't have the permission
>     * requested avaliable.

nit: also mis-spelled in the comments :)

::: extensions/cookie/nsPermissionManager.h:369
(Diff revision 1)
>    /**
>     * Returns false if this permission manager wouldn't have the permission
>     * requested avaliable.
>     *
>     * If aType is nullptr, checks that the permission manager would have all
>     * permissions avaliable for the given principal.

and here

Comment 12

[Johann Hofmann [:johannh]]

Comment on attachment 8943181 [details]
Bug 1376235 - Change PermissionAvaliable to PermissionAvailable.

https://reviewboard.mozilla.org/r/213524/#review219632

::: extensions/cookie/nsPermissionManager.cpp:3372
(Diff revision 1)
>      nsAutoCString permissionKey;
>      // NOTE: GetKeyForPermission accepts a null aType.
>      GetKeyForPermission(aPrincipal, aType, permissionKey);
>  
>      // If we have a pending promise for the permission key in question, we don't
>      // have the permission avaliable, so report a warning and return false.

here, too

Comment 13

[:prathiksha]

Comment on attachment 8943181 [details]
Bug 1376235 - Change PermissionAvaliable to PermissionAvailable.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/213524/diff/1-2/

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b66479caadb
Change PermissionAvaliable to PermissionAvailable. r=johannh

Comment 15

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/7b66479caadb