1353179 - Fix the content process permission available assertion

Status: RESOLVED FIXED

(Core :: Permission Manager, defect)

Description

[Nika Layzell [:nika] (ni? for response)]

When no permission with the given name is available in the content process, this assertion was not firing correctly. This patch is for fixing this problem and also fixing any permission breakage which is discovered in the fallout.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Fix the content process permission assertion, and add support for pre-load permissions

We need the preload permission abstraction to get around the permissions used by
nsContentBlocker, which need to be in the content process before the URL is
loaded. This abstraction should provide a foundation in the future for any other
permissions which act like that, if we discover that they exist.

This hasn't been run through try yet, and I may add additional patches once it
has to fix additional assertion failures which I encounter.

MozReview-Commit-ID: DAVPue8krnH

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Fix the content process permission assertion, and add support for pre-load permissions

I made a typo - fixed.

MozReview-Commit-ID: DAVPue8krnH

Comment 3

[Andrea Marchesini [:baku]]

Comment on attachment 8854545 [details] [diff] [review]
Fix the content process permission assertion, and add support for pre-load permissions

Review of attachment 8854545 [details] [diff] [review]:
-----------------------------------------------------------------

::: extensions/cookie/nsPermissionManager.cpp
@@ +3015,5 @@
>        if (permEntry.mPermission == nsIPermissionManager::UNKNOWN_ACTION) {
>          continue;
>        }
>  
> +      // XXX: This performs extra work, such as in many cases re-computing the

are you planning to do a follow up for this? If yes, can you file a bug. and maybe write the bug id here?

Comment 4

[Nika Layzell [:nika] (ni? for response)]

[Tracking Requested - why for this release]: This lack of an assertion has caused a minor regression from bug 1337056. This bug shouldn't be too big of a deal on nightly but should be fixed before release.

Comment 5

[Marcia Knous [:marcia]]

Tracking 55+ per Comment 4.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e9e4b447bf87
Fix the content process permission assertion, and add support for pre-load permissions, r=baku

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e9e4b447bf87