1376573 - Override the UserAgents inside a ComplexOverride function via UserAgentOverrides.jsm

Status: RESOLVED FIXED

(Web Compatibility :: Interventions, enhancement)

Description

[Dennis Schubert [:denschub]]

In bug 1371335, Ehsan made us aware that we are duplicating some features from `UserAgentOverrides.jsm`. This is true, we did this on purpose, since `UserAgentOverrides.jsm` was not enabled on Desktop. However, this changed and we can now use it on both Desktop and Mobile.

So, to avoid having two implementations for the same thing, we should remove our duplicated code and go back to using `UserAgentOverrides.jsm`.

Comment 1

[Dennis Schubert [:denschub]]

Attachment: Patch - Override the user agents via UserAgentOverrides.jsm

Eric, this patch removes our own listener for the `http-on-useragent-request` event and replaces it with the `ComplexOverride` feature in `UserAgentOverrides.jsm`, since it is now back in Firefox Desktop. This removes the need for us to carry a own implementation of the service listener and should make it easier to maintain in the long run while not affecting our flexibility at all.

Comment 2

[Dennis Schubert [:denschub]]

This was merged, so this bug is fixed. Landing is tracked in bug 1376602.