1376642 - [Form Autofill] Replace the strings "profile" with "address" in preferences

Status: RESOLVED FIXED

(Toolkit :: Form Manager, enhancement)

Description

[Scott Wu [:scottwu]]

We have already replaced some "profile" strings with "address" in Bug 1362911, but there are still some that should be changed, like on the entry point (about:preferences#privacy).

Comment 1

[Scott Wu [:scottwu]]

Attachment: Bug 1376642 - (Part 1) Rename files with the word "profile" with "address" in formautofill.

Review commit: https://reviewboard.mozilla.org/r/161294/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/161294/

Comment 2

[Scott Wu [:scottwu]]

Attachment: Bug 1376642 - (Part 2) Replace "profile" with "address" in formautofill file content.

Review commit: https://reviewboard.mozilla.org/r/161296/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/161296/

Comment 3

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8890220 [details]
Bug 1376642 - (Part 1) Rename files with the word "profile" with "address" in formautofill.

https://reviewboard.mozilla.org/r/161294/#review166644

Comment 4

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8890221 [details]
Bug 1376642 - (Part 2) Replace "profile" with "address" in formautofill file content.

https://reviewboard.mozilla.org/r/161296/#review166646

::: browser/extensions/formautofill/locale/en-US/formautofill.properties:6
(Diff revision 1)
>  # This Source Code Form is subject to the terms of the Mozilla Public
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
>  preferenceGroupTitle = Form Autofill
> -enableProfileAutofill = Enable Profile Autofill
> +enableAddressAutofill = Enable Address Autofill

Isn't it `Autofill addresses`?

Comment 5

[Scott Wu [:scottwu]]

Comment on attachment 8890221 [details]
Bug 1376642 - (Part 2) Replace "profile" with "address" in formautofill file content.

https://reviewboard.mozilla.org/r/161296/#review166646

> Isn't it `Autofill addresses`?

Yes you are right! I'll fix this.

Comment 6

[Scott Wu [:scottwu]]

Comment on attachment 8890221 [details]
Bug 1376642 - (Part 2) Replace "profile" with "address" in formautofill file content.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/161296/diff/1-2/

Comment 7

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8890221 [details]
Bug 1376642 - (Part 2) Replace "profile" with "address" in formautofill file content.

https://reviewboard.mozilla.org/r/161296/#review166692

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/565b8d16b720
(Part 1) Rename files with the word "profile" with "address" in formautofill. r=lchang
https://hg.mozilla.org/integration/autoland/rev/ceac50856fee
(Part 2) Replace "profile" with "address" in formautofill file content. r=lchang

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/565b8d16b720
https://hg.mozilla.org/mozilla-central/rev/ceac50856fee