Closed Bug 1376642 Opened 3 years ago Closed 3 years ago

[Form Autofill] Replace the strings "profile" with "address" in preferences

Categories

(Toolkit :: Form Manager, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: scottwu, Assigned: scottwu)

References

(Blocks 1 open bug)

Details

(Whiteboard: [form autofill:M4] [ETA:7/26])

Attachments

(2 files)

We have already replaced some "profile" strings with "address" in Bug 1362911, but there are still some that should be changed, like on the entry point (about:preferences#privacy).
Assignee: nobody → scwwu
Whiteboard: [form autofill:M4] → [form autofill:M4] [ETA:7/26]
Comment on attachment 8890220 [details]
Bug 1376642 - (Part 1) Rename files with the word "profile" with "address" in formautofill.

https://reviewboard.mozilla.org/r/161294/#review166644
Attachment #8890220 - Flags: review?(lchang) → review+
Comment on attachment 8890221 [details]
Bug 1376642 - (Part 2) Replace "profile" with "address" in formautofill file content.

https://reviewboard.mozilla.org/r/161296/#review166646

::: browser/extensions/formautofill/locale/en-US/formautofill.properties:6
(Diff revision 1)
>  # This Source Code Form is subject to the terms of the Mozilla Public
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
>  preferenceGroupTitle = Form Autofill
> -enableProfileAutofill = Enable Profile Autofill
> +enableAddressAutofill = Enable Address Autofill

Isn't it `Autofill addresses`?
Comment on attachment 8890221 [details]
Bug 1376642 - (Part 2) Replace "profile" with "address" in formautofill file content.

https://reviewboard.mozilla.org/r/161296/#review166646

> Isn't it `Autofill addresses`?

Yes you are right! I'll fix this.
Comment on attachment 8890221 [details]
Bug 1376642 - (Part 2) Replace "profile" with "address" in formautofill file content.

https://reviewboard.mozilla.org/r/161296/#review166692
Attachment #8890221 - Flags: review?(lchang) → review+
Pushed by lchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/565b8d16b720
(Part 1) Rename files with the word "profile" with "address" in formautofill. r=lchang
https://hg.mozilla.org/integration/autoland/rev/ceac50856fee
(Part 2) Replace "profile" with "address" in formautofill file content. r=lchang
https://hg.mozilla.org/mozilla-central/rev/565b8d16b720
https://hg.mozilla.org/mozilla-central/rev/ceac50856fee
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.