Closed Bug 1376805 Opened 7 years ago Closed 7 years ago

stylo: Disable stylo for about:URIs other than about:blank

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: bholley, Assigned: heycam)

References

Details

Attachments

(1 file)

There are various html-backed about: URIs that nonetheless use features that aren't exposed to the web (like XUL tree selectors). We should just use the old style system for those documents until we have full XUL support (bug 1294570).
Assignee: nobody → cam
Status: NEW → ASSIGNED
Comment on attachment 8881820 [details]
Bug 1376805 - Disable stylo for about: pages other than about:blank.

https://reviewboard.mozilla.org/r/152896/#review158036

::: dom/base/nsDocument.cpp:13143
(Diff revision 1)
> +        mDocumentURI->GetSpecIgnoringRef(spec);
> +        isAboutBlank = spec.Equals("about:blank");

Change this to NS_IsAboutBlank.
Attachment #8881820 - Flags: review?(bobbyholley) → review+
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ecf7e90cecf6
Disable stylo for about: pages other than about:blank. r=bholley
This triggers the following very frequent intermittent on Stylo opt (bug 1343701):

REFTEST TEST-UNEXPECTED-FAIL | file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/view-source/view-source-image.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/view-source/view-source-image.html | image comparison, max difference: 4, number of differing pixels: 45000

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=110395935&repo=autoland
Flags: needinfo?(cam)
https://hg.mozilla.org/mozilla-central/rev/ecf7e90cecf6
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Disabled the intermittently failing test in bug 1343701.
Flags: needinfo?(cam)
See Also: → 1378792
Depends on: 1400540
You need to log in before you can comment on or make changes to this bug.