Closed Bug 1376893 Opened 4 years ago Closed 4 years ago

The temporarily disabled state of the reload button should block mouse events without flickering

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: florian, Assigned: jaws)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file)

Currently the reload button is disabled for 650ms right after it appears to prevent accidentally reloading a page when the users tried to stop loading a page that finished loading at the exact same time.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Duplicate of this bug: 1371085
Comment on attachment 8881920 [details]
Bug 1376893 - Don't display the disabled reload button with less opacity since it is only disabled temporarily and causes flickering in the UI.

Thanks for the patch! Looks reasonable to me, but I don't have time to review all the other existing CSS rules applying to #reload-button, so forwarding the request to Johann.
Attachment #8881920 - Flags: review?(florian) → review?(jhofmann)
Comment on attachment 8881920 [details]
Bug 1376893 - Don't display the disabled reload button with less opacity since it is only disabled temporarily and causes flickering in the UI.

https://reviewboard.mozilla.org/r/152986/#review158712

Seems good now, thanks!
Attachment #8881920 - Flags: review?(jhofmann) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a71fc08867b
Don't display the disabled reload button with less opacity since it is only disabled temporarily and causes flickering in the UI. r=johannh
https://hg.mozilla.org/mozilla-central/rev/8a71fc08867b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Depends on: 1378313
Duplicate of this bug: 1368653
You need to log in before you can comment on or make changes to this bug.